----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30920/#review72183 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala <https://reviews.apache.org/r/30920/#comment118188> Would prefer this being a full-fledged method within `object SamzaContainer`. This will make it easier to unit test. Also, we should have some unit tests to validate that this works. - Chris Riccomini On Feb. 12, 2015, 9:04 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30920/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 9:04 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-554 > https://issues.apache.org/jira/browse/SAMZA-554 > > > Repository: samza > > > Description > ------- > > provide a method which looks for the serdes in the system when can not find > in properties file > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 8a6d865 > > Diff: https://reviews.apache.org/r/30920/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
