Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-05-03 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review131526 --- Can you please clarify in the descriptions - what was the issue an

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-29 Thread Alex Buck
> On April 28, 2016, 5:28 p.m., Yi Pan (Data Infrastructure) wrote: > > Hi, @Alex, thanks for the quick update. There is a few more checkstyle > > failures: > > > > :samza-autoscaling_2.10:checkstyleTest > > [ant:checkstyle] > > /home/yipan/workspace/samza_master/samza-autoscaling/src/test/jav

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-29 Thread Alex Buck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/ --- (Updated April 29, 2016, 11:13 a.m.) Review request for samza. Repository: sa

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-28 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review130952 --- Hi, @Alex, thanks for the quick update. There is a few more checks

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-28 Thread Alex Buck
> On April 28, 2016, 12:32 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java, > > line 1 > > > > > > Sorry I missed this one in the revi

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-28 Thread Alex Buck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/ --- (Updated April 28, 2016, 1:41 p.m.) Review request for samza. Repository: sam

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-27 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review130871 --- samza-autoscaling/src/test/java/org/apache/samza/autoscaling/util

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-27 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review130870 --- Ship it! +1 lgtm. Thanks! - Yi Pan (Data Infrastructure) On

Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

2016-04-27 Thread Alex Buck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/ --- Review request for samza. Repository: samza Description --- fix issue wi