----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review130870 -----------------------------------------------------------
Ship it! +1 lgtm. Thanks! - Yi Pan (Data Infrastructure) On April 27, 2016, 10:22 a.m., Alex Buck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46732/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 10:22 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > fix issue with json deserialisation in YarnUtil > > > Diffs > ----- > > > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java > 376c549ededaa04401513752b510a4e6c3a6e386 > > samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java > PRE-CREATION > samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/46732/diff/ > > > Testing > ------- > > Very open to any feedback especially as it's my first review request for > Samza. Thanks > > https://issues.apache.org/jira/browse/SAMZA-930 > > > Thanks, > > Alex Buck > >
