Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

> On April 19, 2016, 12:37 a.m., Vishal Kuo wrote: > > Ship It! This was accidental - Vishal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129458 --

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129603 --- Ship it! Lgtm! Thanks! - Boris Shkolnik On April 19, 2016, 7

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

> On April 19, 2016, 6:23 p.m., Boris Shkolnik wrote: > > bin/grid, line 165 > > > > > > just wondering - why -w 2? -w 1 should work as well? If the port is not > > open it will return right away, will it? Sorry ab

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/ --- (Updated April 19, 2016, 7:39 p.m.) Review request for samza. Changes ---

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129584 --- bin/grid (line 41)

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129458 --- Ship it! Ship It! - Vishal Kuo On April 18, 2016, 6:28 p.m.,

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129419 --- Ship it! Looks good! Thanks for the changes. +1 - Navina Rames

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

> On April 18, 2016, 4:49 p.m., Navina Ramesh wrote: > > bin/grid, line 130 > > > > > > Ah.. Can you add the wait_for_service line here for zookeeper? > > wait_for_service "zookeeper" 2181 Done > On April 18,

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/ --- (Updated April 18, 2016, 6:28 p.m.) Review request for samza. Changes ---

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129365 --- bin/grid (line 130)

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

On April 18, 2016, 5:34 a.m., Vishal Kuo wrote: > > Changes look good except for one minor improvement comment. Also, how does > > this fix help prevent "unit test failures" as you have mentioned in the > > RB's description? Hi Navina, Thanks for the review, the "unit test failures" portion

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/ --- (Updated April 18, 2016, 3:29 p.m.) Review request for samza. Changes ---

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129296 --- bin/grid (line 157)

Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/ --- Review request for samza. Repository: samza-hello-samza Description ---