----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129296 -----------------------------------------------------------
bin/grid (line 157) <https://reviews.apache.org/r/46303/#comment192768> This makes our bootstrap script more robust. I think it will be valuable to make this generic as: wait_for_service(service_name, port_number) Changes look good except for one minor improvement comment. Also, how does this fix help prevent "unit test failures" as you have mentioned in the RB's description? - Navina Ramesh On April 16, 2016, 4:22 p.m., Vishal Kuo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46303/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 4:22 p.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > To prevent kafka dependent services and unit tests to fail intermittently > after bootstrap, a wait_kafka function has been added > > > Diffs > ----- > > bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 > > Diff: https://reviews.apache.org/r/46303/diff/ > > > Testing > ------- > > * Tested normal bootstrap procedure works with additional wait added for kafka > * Tested that timeout occurs if Kafka takes too long to start > > > Thanks, > > Vishal Kuo > >
