Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127927 --- Ship it! lgtm thanks! - Jagadish Venkatraman On April 8, 201

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Chinmay Soman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127925 --- Ship it! - Chinmay Soman On April 8, 2016, 11:40 p.m., Yuanch

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:40 p.m.) Review request for samza. Repository: sam

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote: > > Hi Jagadish, here is the JIRA ticket explaining the change https://issues.apache.org/jira/browse/SAMZA-933 - Yuanchi --- This is an automatically generated e-mail. To reply

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127922 --- Ship it! Changes look good. +1 ! @Yuanchi: Can you link the JIR

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:18 p.m.) Review request for samza. Repository: sam

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:16 p.m.) Review request for samza. Repository: sam

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Navina Ramesh
> On April 8, 2016, 12:04 a.m., Chinmay Soman wrote: > > Lets add a unit test for this. +1 for unit test :) - Navina --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127702 --

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Navina Ramesh
- Navina --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127723 --- On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote: > >

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Navina Ramesh
> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote: > > samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java, > > line 96 > > > > > > Maybe, I'm missing context on this change. Wh

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127723 --- samza-core/src/main/java/org/apache/samza/serializers/model/Samza

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Chinmay Soman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127702 --- Lets add a unit test for this. - Chinmay Soman On April 8, 2016

Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-07 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- Review request for samza. Repository: samza Description --- enable the S