----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127927 -----------------------------------------------------------
Ship it! lgtm thanks! - Jagadish Venkatraman On April 8, 2016, 11:40 p.m., Yuanchi Ning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45912/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 11:40 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, > otherwise it will cause JsonSerde misbehave (wouldn't discover the basic > types like HashMap Entry) > JIRA ticket link: https://issues.apache.org/jira/browse/SAMZA-933 > > > Diffs > ----- > > > samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java > 717b5dcad2aa22540deb08962bf2833e7dc5baa5 > samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala > 4f1c14ce3838163c5af8c9d076238e0ed32619e1 > > Diff: https://reviews.apache.org/r/45912/diff/ > > > Testing > ------- > > > Thanks, > > Yuanchi Ning > >
