Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

> On April 11, 2016, 6:12 p.m., Navina Ramesh wrote: > > samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerListener.java, > > line 128 > > > > > > "satisfied" flag here is simply indicating that w

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

> On April 11, 2016, 6:12 p.m., Navina Ramesh wrote: > > samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java, > > line 69 > > > > > > Why should config be static? > > Jake Maes wrote: >

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 11, 2016, 6:45 p.m.) Review request for samza. Repository: sam

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

> On April 11, 2016, 6:12 p.m., Navina Ramesh wrote: > > samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java, > > line 69 > > > > > > Why should config be static? To ensure that it gets in

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/#review128184 --- Fix it, then Ship it! Thanks for cleaning up the code and fixin

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 11:46 p.m.) Review request for samza. Repository: sam

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

> On April 8, 2016, 8:42 p.m., Chris Pettitt wrote: > > samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java, > > line 59 > > > > > > It looks like this and TestContainerAllocator h

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 11:27 p.m.) Review request for samza. Changes ---

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/#review127874 --- Fix it, then Ship it! samza-yarn/src/test/java/org/apache/samz

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 3:02 p.m.) Review request for samza. Repository: samz

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 7, 2016, 6:30 p.m.) Review request for samza. Changes ---

Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- Review request for samza. Repository: samza Description --- SAMZA-910 Fi