----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ -----------------------------------------------------------
(Updated April 7, 2016, 6:30 p.m.) Review request for samza. Changes ------- Jagadish found 2 issues (thanks!) 1. Failures in the assertions that throw in the allocator thread do not fail the test 2. The assertion for neededContainers in testRerequestOnAnyHostIfContainerStartFails was failing. These are fixed. This should make the tests more reliable and if they fail, they should fail faster. Please give this patch a try. Repository: samza Description ------- SAMZA-910 Fix expired request test in HostAwareContainerAllocator Diffs (updated) ----- samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java b253f98f7258bb611e1ad6672f74b07ab7e20b70 samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java 93e430b6ee986b06ecdac4979552d774724a1fbd samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerListener.java cb82cccf75b54cfbefd586700e8283cb41173833 samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerRequestState.java 879a7d0d06b087cfe0417f3fa5801b43ac7fc458 samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerUtil.java 2f9669f8b7e77abb65b244ccd067ae7ab1f245c3 Diff: https://reviews.apache.org/r/45190/diff/ Testing ------- Thanks, Jake Maes
