Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-09 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review118603 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Feb. 3,

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-05 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review118101 --- Ship it! Ship It! - Jagadish Venkatraman On Feb. 3, 2016, 8:

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-05 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review118073 --- Ship it! samza-yarn/src/main/java/org/apache/samza/job/yarn/Co

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-03 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/ --- (Updated Feb. 3, 2016, 8:04 p.m.) Review request for samza, Navina Ramesh and Y

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-03 Thread Jake Maes
> On Feb. 3, 2016, 2:55 a.m., Jagadish Venkatraman wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 46 > > > > > > I think the javadoc about the run() method may be move

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-03 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/ --- (Updated Feb. 3, 2016, 8:03 p.m.) Review request for samza, Navina Ramesh and Y

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-02 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review117582 --- Ship it! lgtm! Please fix the nits pointed out by Jagadish. s

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-02 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review117555 --- samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContai

Re: Review Request 43074: SAMZA-866 Refactor and fix Container allocation logic.

2016-02-01 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/ --- (Updated Feb. 1, 2016, 11:35 p.m.) Review request for samza, Navina Ramesh and