> On Feb. 3, 2016, 2:55 a.m., Jagadish Venkatraman wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 46 > > <https://reviews.apache.org/r/43074/diff/1/?file=1228848#file1228848line46> > > > > I think the javadoc about the run() method may be moved to the parent > > class. The javadoc for this abstract method can simply talk about allocator > > implementation - that is either host aware or not.
Thanks for catching that. Fixed it! > On Feb. 3, 2016, 2:55 a.m., Jagadish Venkatraman wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 58 > > <https://reviews.apache.org/r/43074/diff/1/?file=1228848#file1228848line58> > > > > nit: Did IDE mess up with some formatting here? Yeah, it was auto-format. It assumed the line was too long. It's a judgment call but I agree it's more readable as one line, so I fixed it. - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43074/#review117555 ----------------------------------------------------------- On Feb. 3, 2016, 8:03 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43074/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 8:03 p.m.) > > > Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > Fixed the code comments and formatting > > > Diffs > ----- > > > samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContainerAllocator.java > 9ee2daccc3c44202308637207a084def81b49c09 > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java > 7c57a866114aabf76a36d3b7ca4c5810628e0c77 > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java > ab3061eae2cfc2da6681ce2034492b165d0d8b96 > > samza-yarn/src/main/java/org/apache/samza/job/yarn/HostAwareContainerAllocator.java > ff22dbfe5537ba2a3c55c4e6063680ff4c9e55f4 > > Diff: https://reviews.apache.org/r/43074/diff/ > > > Testing > ------- > > Unit tests still pass. > > > Thanks, > > Jake Maes > >
