Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

2016-04-14 Thread Navina Ramesh
> On Dec. 15, 2015, 7:59 p.m., Navina Ramesh wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 54 > > > > > > I don't think mentioning RocksDB wiki is necessa

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

2015-12-16 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41365/#review110854 --- Ship it! Ship It! - Boris Shkolnik On Dec. 15, 2015, 11:58 p.m.

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

2015-12-15 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41365/ --- (Updated Dec. 15, 2015, 11:58 p.m.) Review request for samza. Repository: sam

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

2015-12-15 Thread Tao Feng
> On Dec. 15, 2015, 7:59 p.m., Navina Ramesh wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > line 54 > > > > > > I don't think mentioning RocksDB wiki is necessa

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

2015-12-15 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41365/#review110553 --- Ship it! One nit. Otherwise, looks good! samza-kv-rocksdb/src/ma