----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41365/#review110553 -----------------------------------------------------------
Ship it! One nit. Otherwise, looks good! samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line 54) <https://reviews.apache.org/r/41365/#comment170489> I don't think mentioning RocksDB wiki is necessary. You can change it to: "Non-positive TTL for RocksDB implies infinite TTL for the data." - Navina Ramesh On Dec. 14, 2015, 9:04 p.m., Tao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41365/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 9:04 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > rocskdb ttl is handled per RocksDB > semantics(https://github.com/facebook/rocksdb/wiki/Time-to-Live) which zero > or negative ttl is same as infinity ttl. > > > Diffs > ----- > > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > 211fc3be1e168f1f92812406785b39b5a3fd9174 > > Diff: https://reviews.apache.org/r/41365/diff/ > > > Testing > ------- > > ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest > > > Thanks, > > Tao Feng > >
