Re: Review Request 40421: SAMZA-754: fix the null oldestOffset issue in empty topics

2015-11-18 Thread Yi Pan (Data Infrastructure)
> On Nov. 18, 2015, 9:24 p.m., Navina Ramesh wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala, > > line 199 > > > > > > Should we do a similar check for newestOffsets? So f

Re: Review Request 40421: SAMZA-754: fix the null oldestOffset issue in empty topics

2015-11-18 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40421/#review107088 --- Ship it! One question. Otherwise, lgtm! :) samza-kafka/src/main/