> On Nov. 18, 2015, 9:24 p.m., Navina Ramesh wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala, > > line 199 > > <https://reviews.apache.org/r/40421/diff/1/?file=1128986#file1128986line199> > > > > Should we do a similar check for newestOffsets?
So far, I don't see a case where newestOffsets actually matters. Hence, did not change it. - Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40421/#review107088 ----------------------------------------------------------- On Nov. 18, 2015, 1:30 a.m., Yi Pan (Data Infrastructure) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40421/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 1:30 a.m.) > > > Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and > Navina Ramesh. > > > Bugs: SAMZA-754 > https://issues.apache.org/jira/browse/SAMZA-754 > > > Repository: samza > > > Description > ------- > > SAMZA-754: fix the null oldestOffset issue in empty topics > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala > aee33a92941dcf686eed3fcfe7bc8ca01b1ac88b > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala > d260f2d776f567a19cb470100f7c3dc659df690d > > samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala > 6e260bdd14f116fcb05c02f085ca1287bcd9f2ad > > Diff: https://reviews.apache.org/r/40421/diff/ > > > Testing > ------- > > Unit test updated and passed. > > > Thanks, > > Yi Pan (Data Infrastructure) > >
