Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/#review81210 --- Ship it! Ship It! - Jakob Homan On April 22, 2015, 8:11 a.m., Da

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
> On April 20, 2015, 9:55 p.m., Navina Ramesh wrote: > > Can you update the Samza [configuration > > docs](http://samza.apache.org/learn/documentation/latest/jobs/configuration-table.html) > > with info about this re-writer ? Sure, I've added to the configuration-table for this. - Dan

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/ --- (Updated April 22, 2015, 3:11 p.m.) Review request for samza. Repository: sam

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
> On April 17, 2015, 9:23 p.m., Jakob Homan wrote: > > samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java, > > line 41 > > > > > > It may be worth being chatty here in terms of the new confi

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/ --- (Updated April 22, 2015, 2:51 p.m.) Review request for samza. Repository: sam

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-20 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/#review80843 --- Can you update the Samza [configuration docs](http://samza.apache.o

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-17 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/#review80525 --- samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRe