----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/#review80525 -----------------------------------------------------------
samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java <https://reviews.apache.org/r/33305/#comment130502> Need ASF file header. samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java <https://reviews.apache.org/r/33305/#comment130529> It may be worth being chatty here in terms of the new config properties that are being introduced. Better to have some extra info in the startup log and not need it than no info and need it. samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java <https://reviews.apache.org/r/33305/#comment130503> remove dead code samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java <https://reviews.apache.org/r/33305/#comment130507> Can we warn if we are overriding a previously defined key? I can see the potential for difficult-to-debug issues if keys are silently overridden. samza-api/src/test/java/org/apache/samza/config/EnvironmentConfigRewriterTest.java <https://reviews.apache.org/r/33305/#comment130508> Need ASF header - Jakob Homan On April 17, 2015, 6:12 a.m., Dan Harvey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33305/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 6:12 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > [SAMZA-655] Add EnvironmentConfigRewriter to samza-api. > > > Diffs > ----- > > > samza-api/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java > PRE-CREATION > > samza-api/src/test/java/org/apache/samza/config/EnvironmentConfigRewriterTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33305/diff/ > > > Testing > ------- > > > Thanks, > > Dan Harvey > >
