---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36224/#review91251
---
Ship it!
Ship It!
- Naveen Somasundaram
On July 6, 2015, 10:06
ka-console-consumer.sh --zookeeper localhost:2181 --topic
__samza_coordinator_wikipedia-parser_1 --from-beginning
nsomasun@nsomasun-mn1
{"host":"172.21.136.130","source":"CHECKPOINTMIGRATION","values":{"kafka.wikipedia-raw.0":"2103"},"username":"nsomasun","timestamp":1435870948879}
Thanks,
Naveen Somasundaram
ition":"0","offset":"2103","stream":"wikipedia-raw"}}
OUTPUT FROM 0.10.0:
~/Documents/hello-samza(branch:latest) »
deploy/kafka/bin/kafka-console-consumer.sh --zookeeper localhost:2181 --topic
__samza_coordinator_wikipedia-parser_1 --from-beginning
nsomasun@nsomasun-mn1
{"host":"172.21.136.130","source":"CHECKPOINTMIGRATION","values":{"kafka.wikipedia-raw.0":"2103"},"username":"nsomasun","timestamp":1435870948879}
Thanks,
Naveen Somasundaram
-CREATION
samza-test/src/main/config/join/common.properties
ac87e81aeea4015b2fc83942a62e3d16c4fbbd2b
Diff: https://reviews.apache.org/r/35676/diff/
Testing
---
Unit test added, test will hello-samza in progress
Thanks,
Naveen Somasundaram
Hey Yan,
SAMZA-721 might be because you checkout master and switched
to 0.9.1 branch, and you still have some files from master which git is not
tracking. Can you try a git clean before you build 0.9.1 ? AFAIK you don't
need joint compilation for core in 0.9.1.
On Mon, Jun 22, 2015
hello-samza in progress
Thanks,
Naveen Somasundaram
+1
> On Jun 16, 2015, at 7:41 PM, Shekar Tippur wrote:
>
> +1
> On Jun 16, 2015 6:39 PM, "Percy Wegmann" wrote:
>
>> Thank you!
>>
>> Sent using CloudMagic<
>> https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.2>
>>
>> On Tue, Jun 16, 2015 at 8:11 PM, Chris Riccomini
>> wrote:
>> +1
Hey Shekar,
You can also use the RollingFileAppender. You can both
specify the maximum number of files and the maximum number of files you want to
keep.
https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/RollingFileAppender.html#maxBackupIndex
On May 14, 2015, at
This kind of polymorphism should be accomplished via virtual methods;
> > extend and override. The factory should inspect the config, and determine
> > whether to return a RocksDbKeyValueStore or a RocksDbKeyValueStoreWithTtl
>
> Naveen Somasundaram wrote:
> I am n
samza/storage/kv/TestRocksDbKeyValueStore.scala
PRE-CREATION
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
9dee7be9a58c491dbd1a6b9cf73d5c111c570da2
Diff: https://reviews.apache.org/r/33735/diff/
Testing
---
Added Unit test
Thanks,
Naveen Somasundaram
alueStore.scala
> PRE-CREATION
>
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
> 50dfc10bb053d74dba70fdbce0ef87609ba447ea
>
> Diff: https://reviews.apache.org/r/33735/diff/
>
>
> Testing
> ---
>
> Added Unit test
>
>
> Thanks,
>
> Naveen Somasundaram
>
>
sDB version in our
dependency and it breaks TTL. The latter is not supported AFAIK, lmk otherwise,
I can integrate.
- Naveen
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33735/#review83438
-
/RocksDbKeyValueStorageEngineFactory.scala
<https://reviews.apache.org/r/33735/#comment133369>
Makes sense, changed to rocksDbHandle
- Naveen Somasundaram
On April 30, 2015, 11:21 p.m., Naveen Somasundaram wrote:
>
> ---
PRE-CREATION
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33735/diff/
Testing
---
Added Unit test
Thanks,
Naveen Somasundaram
kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
> PRE-CREATION
>
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
> 50dfc10bb053d74dba70fdbce0ef87609ba447ea
>
> Diff: https://reviews.apache.org/r/33735/diff/
>
>
> Testing
> ---
>
> Added Unit test
>
>
> Thanks,
>
> Naveen Somasundaram
>
>
samza-core/src/main/scala/org/apache/samza/util/Util.scala
<https://reviews.apache.org/r/33453/#comment133363>
nit: log ("CRC doesn't match, data corrupted, skipping file") or something
along those lines.
- Naveen Somasundaram
On May
pache/samza/storage/kv/TestKeyValueStores.scala
50dfc10bb053d74dba70fdbce0ef87609ba447ea
Diff: https://reviews.apache.org/r/33735/diff/
Testing
---
Added Unit test
Thanks,
Naveen Somasundaram
ally, we do not need the consumer after boostrapping, right? Do we
> > stop it?
>
> Naveen Somasundaram wrote:
> We use the same consumer for both the checkpoint and changelog. The
> checkpoint consumer needs to live for the entire lifespan of the Job (Hence
> the coordinator
ill this bootstrappedStreamSet overflow or take a lot of memory ?
> > Because we are putting all the messages in the stream to this map. When we
> > consider the checkpoint msg, it can be huge.
>
> Naveen Somasundaram wrote:
> It is true that we'll have multiple che
--
On April 10, 2015, 3:13 a.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32147/
> --
reviews.apache.org/r/32147/#review81995
---
On April 10, 2015, 3:13 a.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To re
- Naveen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32147/#review81995
---
On April 10, 2015, 3:13 a.m., Naveen Somasundaram wrote
erence between the old and
new config):
```
(oldConfig.keySet -- config.keySet).foreach(key => {
coordinatorSystemProducer.send(new
CoordinatorStreamMessage.Delete(JobRunner.SOURCE, key, SetConfig.TYPE))
})
```
> On April 29, 2015, 7:30 p.m., Yan Fang wrote:
>
you are
referring to ?
- Naveen Somasundaram
On April 10, 2015, 3:13 a.m., Naveen Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review81387
---
LGTM!
- Naveen Somasundaram
On April 23, 2015, 6:18 p.m., Dan
/BatchingKeyValueStore.java
<https://reviews.apache.org/r/33146/#comment131696>
Can you please document this? as an end-user, it would be nice to know the
behavior.
- Naveen Somasundaram
On April 23, 2015, 7:44 a.m., Mohamed Mahmoud (El-Geish)
/elasticsearch/ElasticsearchSystemProducer.java
<https://reviews.apache.org/r/33297/#comment131436>
If the previous send has failed, i.e., sendFailed is true here, shouldn't
we throw an exception here ? Otherwise it might result in message develivered
out of order.
- Naveen Somasundaram
/yarn/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/33199/diff/
Testing
---
Full changes for coordinator stream.
Same as:
https://reviews.apache.org/r/32147/
Thanks,
Naveen Somasundaram
/BatchingKeyValueStore.java
<https://reviews.apache.org/r/33146/#comment129891>
What's the significance of the null check ? why not just return null values
and the let the application decide what to do with it.
- Naveen Somasundaram
On April 13, 2015, 9:24 p.m., Mohamed Mahmoud (El-G
til.scala, line 146
> > <https://reviews.apache.org/r/32147/diff/3-5/?file=911585#file911585line146>
> >
> > I don't think that you need to parameterize this (the {}). SLF4J's
> > Logger takes an error(String, Throwable) ..
> > http://w
from the
"systemconsumers" and "systemproducers" we have (This will be done after
SAMZA-567)
3. Remove checkpoint configs related to the stream, migrate them to the
coordinator stream and document them.
Thanks,
Naveen Somasundaram
e the code alone
> > everywhere.
Because of java vs scala. Java doesn't undestand default constructor args. I
have added two constructors, looks better now.
- Naveen
-------
This is an automatically generated e-mail. To reply, visit:
htt
coordinator stream and document them.
Thanks,
Naveen Somasundaram
systemproducers" we have (This will be done after
SAMZA-567)
3. Remove checkpoint configs related to the stream, migrate them to the
coordinator stream and document them.
Thanks,
Naveen Somasundaram
systemproducers" we have (This will be done after
SAMZA-567)
3. Remove checkpoint configs related to the stream, migrate them to the
coordinator stream and document them.
Thanks,
Naveen Somasundaram
/config/perf/container-performance.properties
<https://reviews.apache.org/r/32147/#comment126533>
It should, but the code does that automatically, so this is redundant, I'll
remove it from the config.
samza-test/src/main/python/samza_failure_testing.py
<https://reviews.apache.org/r/321
Hey Ash,
1. Did you happen to modify your log4j.xml ?
2. Can you print the class path that was printed when the job
started ? I am wondering if log4j was not loaded or not present in the path
where it’s looking for. If you have been using hello samza, it should have
Hey Jae,
I verified passing Java properties with the property you specified and it
seems to be working fine. However, if I pass the same properties to the
hello-samza, it fails with same error you have. I have opened a bug to track
this here:
https://issues.apache.org/jira/browse/SAMZA-60
unit tests pass
- All Integration tests pass
- Torture tests in running (no issues so far..)
Thanks,
Naveen Somasundaram
ument them.
Thanks,
Naveen Somasundaram
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/#review76818
---
Ship it!
Ship It!
- Naveen Somasundaram
On March 17, 2015, 7:01
/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/32127/#comment124475>
https://issues.apache.org/jira/browse/SAMZA-393 seems to be something else ?
- Naveen Somasundaram
On March 17, 2015, 7:01 a.m., Chris Riccomini
reference to it
2. The coordinator stream does not use the same consumer and producer from the
"systemconsumers" and "systemproducers" we have (This will be done after
SAMZA-567)
Thanks,
Naveen Somasundaram
/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/32147/diff/
Testing
---
Thanks,
Naveen Somasundaram
://reviews.apache.org/r/32147/diff/
Testing
---
Thanks,
Naveen Somasundaram
/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/32135/diff/
Testing
---
Thanks,
Naveen Somasundaram
Diff: https://reviews.apache.org/r/32135/diff/
Testing
---
Thanks,
Naveen Somasundaram
is comment make sense anymore?
removed
- Naveen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31718/#review75489
---
On March 16, 201
ppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/31718/diff/
Testing
---
Thanks,
Naveen Somasundaram
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
<https://reviews.apache.org/r/31718/#comment124249>
removed
- Naveen Somasundaram
On March 4, 2015, 1:39 a.m., Naveen Somasundaram wrote:
>
> --
and update the RB. Sorry for
the confusion.
- Naveen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31718/#review75489
---
g/r/31718/diff/
Testing
---
Thanks,
Naveen Somasundaram
amza/checkpoint/OffsetManager.scala
<https://reviews.apache.org/r/31718/#comment122067>
will remove
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
<https://reviews.apache.org/r/31718/#comment122069>
will revert, changed for debugging.
- Nav
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31417/#review74715
---
On Feb. 25, 2015, 5:45 p.m., Naveen Somasundaram wrote:
>
> ---
-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/31718/diff/
Testing
---
Thanks,
Naveen Somasundaram
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/31718/diff/
Testing
---
Thanks,
Naveen Somasundaram
2f01b2
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/31417/diff/
Testing
---
Thanks,
Naveen Somasundaram
eviews.apache.org/r/31417/diff/
Testing
---
Thanks,
Naveen Somasundaram
pMasterService.scala
81dea9d6d1921462b200c62dbdf016c0eb2f01b2
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
58f2464211a1fb7ff40f5978fd41f64d088002d0
Diff: https://reviews.apache.org/r/31417/diff/
Testing
---
Thanks,
Naveen Somasundaram
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review73830
---
Ship it!
Ship It!
- Naveen Somasundaram
On Feb. 23, 2015, 12:23
+1
On Jan 30, 2015, at 9:22 AM, Chris Riccomini wrote:
> Hey all,
>
> I'm planning on opening a post-0.9.0 ticket. I was going to go with 0.10.0.
> Is everyone good with that? Some people are kind of finicky about
> double-digit minor version numbers.
>
> Cheers,
> Chris
61 matches
Mail list logo
