> On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > build.gradle, line 34 > > <https://reviews.apache.org/r/33735/diff/1/?file=946534#file946534line34> > > > > remember to remove the space. :)
I have published it to maven, getting rid of this :) > On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, lines > > 1009-1010 > > <https://reviews.apache.org/r/33735/diff/1/?file=946535#file946535line1009> > > > > why do we remove the bloomfilter? Apparently this is only supported in https://github.com/facebook/rocksdb/wiki/PlainTable-Format. We use the block based format, we can't use plain table format because it doesn't support iterator.prev(). > On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala, > > line 49 > > <https://reviews.apache.org/r/33735/diff/1/?file=946537#file946537line49> > > > > do we follow the same name fashion? using rocksDbHandle instead? Makes sense, fixed. > On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, > > lines 78-80 > > <https://reviews.apache.org/r/33735/diff/1/?file=946538#file946538line78> > > > > 1. throw Exception when the value is not int? > > 2. add warning/info messages for this setting. Because if this is set > > too low accidently, at least we have a place to check. 1. Done 2. Done - Naveen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review82237 ----------------------------------------------------------- On April 30, 2015, 11:21 p.m., Naveen Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33735/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 11:21 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > RocksDB TTL support > https://issues.apache.org/jira/browse/SAMZA-537 > https://issues.apache.org/jira/browse/SAMZA-442 > > Please ignore the maven link added to build.gradle, I'll remove it once I > validate the release is good. > > > Diffs > ----- > > build.gradle ebad6eb27372d13bdb76506db2d4372b128f3c1e > docs/learn/documentation/versioned/jobs/configuration-table.html > 728197d01d1e3f551ea53e2a14e97df44e29ee19 > gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala > 5ab68590a4ed2686d730344665e25776cade6add > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > 66c2a0dc2e38e21f951727a30f0987776ac52fe2 > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala > PRE-CREATION > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > 50dfc10bb053d74dba70fdbce0ef87609ba447ea > > Diff: https://reviews.apache.org/r/33735/diff/ > > > Testing > ------- > > Added Unit test > > > Thanks, > > Naveen Somasundaram > >
