Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 27, 2016, 12:03 a.m.) Review request for samza, Boris Shkolnik,

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 26, 2016, 11:35 p.m.) Review request for samza, Boris Shkolnik,

Re: Mini Samza

2016-04-26 Thread Jagadish Venkatraman
Hi Ben, Could you please share a link to your 'mini_samza' project? Thanks, Jagadish On Tue, Apr 26, 2016 at 3:49 PM, Ben Thorner wrote: > Hi guys. >Apologies if this isn't the right place to send this! >I've recently been learning to use Samza, but found it quite hard (new > to Kafka,

Mini Samza

2016-04-26 Thread Ben Thorner
Hi guys. Apologies if this isn't the right place to send this! I've recently been learning to use Samza, but found it quite hard (new to Kafka, ZooKeeper, Gradle, YARN, etc.). I just knew Samza would be a good solution for my problem, after reading what it can do. The hello-samza project

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 26, 2016, 8:56 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Jagadish Venkatraman
> On April 26, 2016, 12:23 a.m., Yi Pan (Data Infrastructure) wrote: > > Overall, ltgm. Only a few comments to be addressed. One high level comment > > is that we don't need a refactor in the package path to indicate that we > > are refactoring. :) Thanks! > > Yi Pan (Data Infrastructure) wrot

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Jagadish Venkatraman
> On April 25, 2016, 7:03 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java, > > line 147 > > > > > > nit: I think that I commente

Re: Review Request 46546: SAMZA-940 TestProcessJob.testProcessJobKillShouldWork fails occasionally

2016-04-26 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46546/#review130669 --- Ship it! Ship It! - Boris Shkolnik On April 22, 2016, 12:08

Re: Review Request 46282: SAMZA-928 document Kerberos on YARN

2016-04-26 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46282/#review130660 --- Fix it, then Ship it! Lgtm overall! Thanks a lot! docs/learn/

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-26 Thread Yi Pan (Data Infrastructure)
> On April 26, 2016, 12:23 a.m., Yi Pan (Data Infrastructure) wrote: > > Overall, ltgm. Only a few comments to be addressed. One high level comment > > is that we don't need a refactor in the package path to indicate that we > > are refactoring. :) Thanks! BTW, it seems that a rebase against t