----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46282/#review130660 -----------------------------------------------------------
Fix it, then Ship it! Lgtm overall! Thanks a lot! docs/learn/documentation/versioned/yarn/yarn-security.md (line 28) <https://reviews.apache.org/r/46282/#comment194491> nit: remove *config*, we can directly refer to the coordinator stream docs/learn/documentation/versioned/yarn/yarn-security.md (line 30) <https://reviews.apache.org/r/46282/#comment194492> nit: config stream --> coordinator stream docs/learn/documentation/versioned/yarn/yarn-security.md (line 34) <https://reviews.apache.org/r/46282/#comment194500> Question: wouldn't the running container needs a HDFS delegation token to access secured HDFS to read the credential files as well? How is the initial HDFS delegation token passed to the container? Via launch context from RM? It would be good to add some explanation, or pointing to some online docs for general YARN APP launch sequence w/ Kerberos. docs/learn/documentation/versioned/yarn/yarn-security.md (line 48) <https://reviews.apache.org/r/46282/#comment194503> nit: trailing white space docs/learn/documentation/versioned/yarn/yarn-security.md (line 62) <https://reviews.apache.org/r/46282/#comment194504> nit: trailing white space docs/learn/documentation/versioned/yarn/yarn-security.md (line 63) <https://reviews.apache.org/r/46282/#comment194505> Cool! If this works, feel free to close SAMZA-929! - Yi Pan (Data Infrastructure) On April 15, 2016, 10:09 p.m., Chen Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46282/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 10:09 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-928 document Kerberos on YARN > > > Diffs > ----- > > docs/learn/documentation/versioned/jobs/yarn-jobs.md 827cc14 > docs/learn/documentation/versioned/yarn/isolation.md 1eb3bf5 > docs/learn/documentation/versioned/yarn/yarn-security.md PRE-CREATION > > Diff: https://reviews.apache.org/r/46282/diff/ > > > Testing > ------- > > > Thanks, > > Chen Song > >
