Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127927 --- Ship it! lgtm thanks! - Jagadish Venkatraman On April 8, 201

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

2016-04-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 11:46 p.m.) Review request for samza. Repository: sam

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

2016-04-08 Thread Jake Maes
> On April 8, 2016, 8:42 p.m., Chris Pettitt wrote: > > samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java, > > line 59 > > > > > > It looks like this and TestContainerAllocator h

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Chinmay Soman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127925 --- Ship it! - Chinmay Soman On April 8, 2016, 11:40 p.m., Yuanch

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:40 p.m.) Review request for samza. Repository: sam

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

2016-04-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 11:27 p.m.) Review request for samza. Changes ---

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote: > > Hi Jagadish, here is the JIRA ticket explaining the change https://issues.apache.org/jira/browse/SAMZA-933 - Yuanchi --- This is an automatically generated e-mail. To reply

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127922 --- Ship it! Changes look good. +1 ! @Yuanchi: Can you link the JIR

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:18 p.m.) Review request for samza. Repository: sam

Re: Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper

2016-04-08 Thread Yuanchi Ning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/ --- (Updated April 8, 2016, 11:16 p.m.) Review request for samza. Repository: sam

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-08 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 8, 2016, 10:01 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-08 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 8, 2016, 9:44 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-08 Thread Jagadish Venkatraman
> On April 7, 2016, 11:13 p.m., Navina Ramesh wrote: > > Overall, the class structure looks good for the first iteration. For > > duplicate classes in the new namespace, I didn't look into great detail as > > I expect that you will sync-up with the master before committing. > > Please fix java

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

2016-04-08 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/#review127874 --- Fix it, then Ship it! samza-yarn/src/test/java/org/apache/samz

Re: Kafka 0.9 as part of Samza 0.10?

2016-04-08 Thread Neha Narkhede
Nick, The relationship between Kafka Connect and any stream processing system (whether it is Samza, Kafka Streams or anything else) is very complementary. Kafka Connect makes data available in K

Re: Review Request 45190: SAMZA-910 Fix expired request test in HostAwareContainerAllocator

2016-04-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45190/ --- (Updated April 8, 2016, 3:02 p.m.) Review request for samza. Repository: samz