Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

2015-11-19 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40525/#review107321 --- Ship it! samza-kv-rocksdb/src/test/scala/org/apache/samza/storage

Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

2015-11-19 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40525/#review107320 --- samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRo

Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

2015-11-19 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40525/#review107319 --- Ship it! lgtm - Jagadish Venkatraman On Nov. 20, 2015, 6:18 a.m

Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

2015-11-19 Thread tao feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40525/ --- Review request for samza. Repository: samza Description --- 1. implement

Re: Avro vs Protocol buffer for Samza output

2015-11-19 Thread Selina Tech
Hi, Yi: Thanks a lot for your reply with information about Avro schema registry. I studied the Avro message on Kafka after your reply, the Avro message will automatically have [magic byte][schema id][actual message] after encode. Your mentioned " It is a specific way of maintain

Re: Review Request 40472: SAMZA-816: avoid creating and registering CoordinatorSystemConsumer in LocalityManager in SamzaContainer

2015-11-19 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40472/#review107253 --- Ship it! A few nits. Fix them and then, +1 ! samza-core/src/main

Re: Sample code or tutorial for writing/reading Avro type message in Samza

2015-11-19 Thread Luis Casillas
I did a Samza proof of concept project recently and I ended up writing this code: https://gist.github.com/ldcasillas-progreso/871af3c1a1790be975fd In the end, however, I switched the project from Avro to JSON. The issue is that Avro is designed to work with its self-describing container file

Re: Review Request 40457: SAMZA-788 - coordinator stream configuration should not guess the system names

2015-11-19 Thread Navina Ramesh
> On Nov. 19, 2015, 5:59 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala, > > line 72 > > > > > > The patch to SAMZA-754 already added

Re: Review Request 40457: SAMZA-788 - coordinator stream configuration should not guess the system names

2015-11-19 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40457/ --- (Updated Nov. 19, 2015, 10:05 p.m.) Review request for samza, Boris Shkolnik, Y

Re: Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere

2015-11-19 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40485/#review107232 --- Ship it! samza-yarn/src/main/scala/org/apache/samza/job/yarn/Yarn

Re: Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere

2015-11-19 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40485/#review107221 --- Ship it! Agree. Fix the nit and then +1 ! - Navina Ramesh On No

Re: Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere

2015-11-19 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40485/#review107215 --- Ship it! Fix the nit and +1 samza-yarn/src/main/scala/org/apache

Re: Review Request 40457: SAMZA-788 - coordinator stream configuration should not guess the system names

2015-11-19 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40457/#review107209 --- Ship it! LGTM except one comment. samza-test/src/test/scala/org/

Re: question on yarn.container.cpu.cores

2015-11-19 Thread Jagadish Venkatraman
Hi Chen, Yes, theoretically, it's possible and it'll certainly increase parallelism. You should be careful about auto-commit when you implement this, Say you have auto-commit turned on, and do a time-consuming operation for certain types of messages in your process method (like - a long computati

Re: question on yarn.container.cpu.cores

2015-11-19 Thread Rick Mangi
I’m not sure you can do this for the purposes of consuming messages faster, but I’m interested to hear if I’m mistaken. You could spawn threads to do other work within a job though. > On Nov 18, 2015, at 11:40 PM, Chen Song wrote: > > Thanks Navina > > So theoretically I can create a threa

Review Request 40485: SAMZA-767 yarn.queue option is not used anywhere

2015-11-19 Thread Aleksandar Pejakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40485/ --- Review request for samza. Repository: samza Description --- Added missin