----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40457/#review107209 -----------------------------------------------------------
Ship it! LGTM except one comment. samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala (line 72) <https://reviews.apache.org/r/40457/#comment166220> The patch to SAMZA-754 already added this to StreamTaskTestUtils. - Yi Pan (Data Infrastructure) On Nov. 18, 2015, 10:13 p.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40457/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 10:13 p.m.) > > > Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jagadish > Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-788 > https://issues.apache.org/jira/browse/SAMZA-788 > > > Repository: samza > > > Description > ------- > > SAMZA-788 - coordinator stream configuration should not guess the system names > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala > 6d73bb9d3ef9c95445ec7c5f539d6e6279286a73 > > samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamWriter.java > f9c630419bc355d03c28e3221acde9efd8e17ae6 > samza-core/src/test/resources/test-migration-fail.properties > b0657defeebe5ed61ebc7f1dfa7688a583071fe1 > samza-core/src/test/resources/test.properties > 41eb82eb673a82fa75f464c69000ddcde0bd17cb > > samza-test/src/test/scala/org/apache/samza/test/integration/TestShutdownStatefulTask.scala > 06a107bdc180c4590d5f2225639b8455da8edc91 > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 224090333f26715024b4e2eb39f095e64927ed01 > > Diff: https://reviews.apache.org/r/40457/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Navina Ramesh > >
