Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-27 Thread Roger Hoover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 28, 2015, 6:13 a.m.) Review request for samza. Changes ---

Re: Review Request 35445: SAMZA-693: Very basic HDFS Producer service for Samza

2015-07-27 Thread Eli Reisman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35445/ --- (Updated July 28, 2015, 5:25 a.m.) Review request for samza. Repository: samz

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-27 Thread Shadi A. Noghabi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/ --- (Updated July 28, 2015, 2:39 a.m.) Review request for samza, Yi Pan (Data Infra

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-27 Thread Shadi A. Noghabi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/ --- (Updated July 28, 2015, 2:22 a.m.) Review request for samza, Yi Pan (Data Infra

no new topic created on Kafka

2015-07-27 Thread Job-Selina Wu
Hi, Dear All: I have two Tasks at Samza. HttpDemoParserStreamTask and HttpDemoStatsStreamTask. They are almost same, except the output topic name is different and the task name are different at properties file. I am wondering how should I debug on it? More details are list below. Al

Re: Review Request 36768: SAMZA-740: Add ElasticsearchProducer example to samza-hello-samza

2015-07-27 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36768/#review93137 --- I think it's ok to keep the elastic grid seperate, though there is a

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

2015-07-27 Thread József Márton Jung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 27, 2015, 10:15 a.m.) Review request for samza. Repository: sam

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

2015-07-27 Thread József Márton Jung
> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 627 > > > > > > LocalityManager maintains "container to host"-level mapping

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

2015-07-27 Thread József Márton Jung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 27, 2015, 10:11 a.m.) Review request for samza. Changes ---

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

2015-07-27 Thread József Márton Jung
> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36692: SAMZA-717 Expose the TaskNameGrouper API

2015-07-27 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36692/#review93097 --- Ship it! The code LGTM. I just realized that when we expose this vi

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

2015-07-27 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review93093 --- The code LGTM. For testing, if we can verify this fix w/ a stateful