----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36768/#review93137 -----------------------------------------------------------
I think it's ok to keep the elastic grid seperate, though there is a little redundant code. Because conceptally they are different - this one is totally an add-on, while the "main" grid is for the Samza-must-have compoenents. bin/grid-elastic (line 53) <https://reviews.apache.org/r/36768/#comment147398> remove space bin/grid-elastic (line 121) <https://reviews.apache.org/r/36768/#comment147399> remove space bin/grid-elastic (line 127) <https://reviews.apache.org/r/36768/#comment147400> remove the space - Yan Fang On July 24, 2015, 8:31 a.m., Stuart Davidson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36768/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 8:31 a.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > I'd put together an example of how to use the new ElasticsearchProvider for > my work colleagues and I thought it'd be worth submitting it back to the > community. This also includes a script to start elasticsearch and kibana on > the host - be aware, there's a 64bit version depending on what machine you > want to run against. > > Also note, this is against 0.10.0 of Samza which is not released yet. I am > making the assumption that the Elasticsearch jars are bundled as part of that > - if not, we'll need to add them to the POM here. > > > Diffs > ----- > > bin/grid-elastic PRE-CREATION > pom.xml f9c4fa9 > src/main/assembly/src.xml f57fee2 > src/main/config/wikipedia-elastic.properties PRE-CREATION > src/main/java/samza/examples/wikipedia/task/WikipediaElasticStreamTask.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36768/diff/ > > > Testing > ------- > > > Thanks, > > Stuart Davidson > >
