[GitHub] merlimat commented on a change in pull request #574: Documentation changes

2017-07-24 Thread git
merlimat commented on a change in pull request #574: Documentation changes URL: https://github.com/apache/incubator-pulsar/pull/574#discussion_r129186879 ## File path: site/_includes/navbar.html ## @@ -90,11 +92,11 @@ Apache http://www.apache.org/foundation/spons

[GitHub] merlimat commented on a change in pull request #574: Documentation changes

2017-07-24 Thread git
merlimat commented on a change in pull request #574: Documentation changes URL: https://github.com/apache/incubator-pulsar/pull/574#discussion_r129222380 ## File path: site/docs/latest/advanced/PartitionedTopics.md ## @@ -0,0 +1,88 @@ +--- +title: Partitioned topics +lead:

[GitHub] merlimat commented on a change in pull request #574: Documentation changes

2017-07-24 Thread git
merlimat commented on a change in pull request #574: Documentation changes URL: https://github.com/apache/incubator-pulsar/pull/574#discussion_r129221720 ## File path: site/docs/latest/adaptors/PulsarSpark.md ## @@ -3,9 +3,9 @@ title: Spark Streaming Pulsar receiver tags:

[GitHub] merlimat commented on a change in pull request #574: Documentation changes

2017-07-24 Thread git
merlimat commented on a change in pull request #574: Documentation changes URL: https://github.com/apache/incubator-pulsar/pull/574#discussion_r129221412 ## File path: site/_includes/explanations/partitioned-topics.md ## @@ -1,19 +1,31 @@ -Normal topics can be served only b

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129212256 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersi

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129213798 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersi

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129182034 ## File path: pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LoadReport

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129182803 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheManager.j

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129212179 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersi

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129182185 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundle.java #

[GitHub] merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic

2017-07-24 Thread git
merlimat commented on a change in pull request #538: Make broker configurable to own non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129187510 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java

[GitHub] yush1ga commented on issue #586: Add athenz authentication plugin for C++ client

2017-07-24 Thread git
yush1ga commented on issue #586: Add athenz authentication plugin for C++ client URL: https://github.com/apache/incubator-pulsar/pull/586#issuecomment-317627476 @saandrews > Can you create a pull request against Athens to get the ZTSClient? I may have to add many codes to create

[GitHub] yush1ga commented on issue #586: Add athenz authentication plugin for C++ client

2017-07-24 Thread git
yush1ga commented on issue #586: Add athenz authentication plugin for C++ client URL: https://github.com/apache/incubator-pulsar/pull/586#issuecomment-317627476 @saandrews > Can you create a pull request against Athens to get the ZTSClient? I have to add many codes to create a PR

[GitHub] yush1ga commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-07-24 Thread git
yush1ga commented on a change in pull request #543: Added documents for wildcard matching in authorization URL: https://github.com/apache/incubator-pulsar/pull/543#discussion_r129210442 ## File path: site/_includes/explanations/permissions.md ## @@ -14,6 +14,37 @@ $ pulsar

[GitHub] jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590#issuecomment-317603127 > Are we controlling the logger object destruction? No, it is a boost::thread_specific static object > Ha

[GitHub] jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590#issuecomment-317603127 > Are we controlling the logger object destruction? No, it is a boost::thread_specific static object > Have y

[GitHub] jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
jai1 commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590#issuecomment-317603127 > Are we controlling the logger object destruction? No, it is a boost::thread_specific static object > Ha

[GitHub] jai1 closed pull request #595: CPP Client Test for Lookup Issue (#551)

2017-07-24 Thread git
jai1 closed pull request #595: CPP Client Test for Lookup Issue (#551) URL: https://github.com/apache/incubator-pulsar/pull/595 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] jai1 opened a new pull request #595: CPP Client Test for Lookup Issue (#551)

2017-07-24 Thread git
jai1 opened a new pull request #595: CPP Client Test for Lookup Issue (#551) URL: https://github.com/apache/incubator-pulsar/pull/595 - Added Test case to check if consumer and producer are reconnecting after connection close. - Changed topic names in the test case to make them more logi

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Matteo Merli
Ok, my question was also on the line: "is anyone ok in doing a release now" ? :) > Instruction seems to be detailed. Though I will only be able to add > meaningful comment when I attempt these(volunteer for a release > manager) :) Sure, the wiki is a living document. Anyone should feel free to up

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Sahaya Andrews
Instruction seems to be detailed. Though I will only be able to add meaningful comment when I attempt these(volunteer for a release manager) :) Slightly off topic question: Are we not using Jenkins for the build? Andrews. On Mon, Jul 24, 2017 at 3:20 PM, Dave Fisher wrote: > >> On Jul 24, 2017,

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Dave Fisher
> On Jul 24, 2017, at 3:09 PM, Matteo Merli wrote: > > I have created a wiki page with the WIP instructions for the release > > https://github.com/apache/incubator-pulsar/wiki/Release-process > > I also have created an INFRA ticket to create the Nexus project so that we > can publish maven art

[GitHub] merlimat closed pull request #594: Enable Apache rat in CI builds

2017-07-24 Thread git
merlimat closed pull request #594: Enable Apache rat in CI builds URL: https://github.com/apache/incubator-pulsar/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Matteo Merli
I have created a wiki page with the WIP instructions for the release https://github.com/apache/incubator-pulsar/wiki/Release-process I also have created an INFRA ticket to create the Nexus project so that we can publish maven artifacts. https://issues.apache.org/jira/browse/INFRA-14694 Any comm

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Matteo Merli
Thanks Dave, I think I'll try with some of my colleagues here. I'll let you know if I can make it. -- Matteo Merli On Mon, Jul 24, 2017 at 1:06 PM, Dave Fisher wrote: > > > On Jul 24, 2017, at 12:33 PM, Matteo Merli > wrote: > > > > Bay area. Who can I get to sign it? Can any other Apache c

[GitHub] merlimat opened a new pull request #594: Enable Apache rat in CI builds

2017-07-24 Thread git
merlimat opened a new pull request #594: Enable Apache rat in CI builds URL: https://github.com/apache/incubator-pulsar/pull/594 ### Motivation Enable Apache RAT check in CI builds to check for license compliance. -

[GitHub] merlimat closed pull request #591: Fixed references to Yahoo pages

2017-07-24 Thread git
merlimat closed pull request #591: Fixed references to Yahoo pages URL: https://github.com/apache/incubator-pulsar/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on G

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Dave Fisher
> On Jul 24, 2017, at 12:33 PM, Matteo Merli wrote: > > Bay area. Who can I get to sign it? Can any other Apache committer (or PMC > from other projects) do it? Yes, if they have participated in a key signing. I am in the North Bay myself and recently met someone to sign their key. We could m

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Matteo Merli
Bay area. Who can I get to sign it? Can any other Apache committer (or PMC from other projects) do it? -- Matteo Merli On Mon, Jul 24, 2017 at 12:27 PM, Dave Fisher wrote: > > > On Jul 24, 2017, at 12:23 PM, Matteo Merli wrote: > > > > On Mon, Jul 24, 2017 at 11:39 AM, Dave Fisher > wrote: >

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Dave Fisher
> On Jul 24, 2017, at 12:23 PM, Matteo Merli wrote: > > On Mon, Jul 24, 2017 at 11:39 AM, Dave Fisher wrote: >> >>> Does for podlings work in the same way as for TLPs? Should we design a >>> release manager? >> >> Yes. I see you created a KEYS file. If someone else is Release Manager >> then

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Matteo Merli
On Mon, Jul 24, 2017 at 11:39 AM, Dave Fisher wrote: > > > Does for podlings work in the same way as for TLPs? Should we design a > > release manager? > > Yes. I see you created a KEYS file. If someone else is Release Manager > then they can add their key as well. > > BTW - Is your Key Signed an

[GitHub] merlimat closed pull request #592: Added script to sign release artifacts

2017-07-24 Thread git
merlimat closed pull request #592: Added script to sign release artifacts URL: https://github.com/apache/incubator-pulsar/pull/592 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] rdhabalia opened a new pull request #593: Local-policies cache should copy global-policy data and return combin?

2017-07-24 Thread git
rdhabalia opened a new pull request #593: Local-policies cache should copy global-policy data and return combin? URL: https://github.com/apache/incubator-pulsar/pull/593 ?ed result ### Motivation after creating namespace, if we try to get `LocalZooKeeperCacheService.localPoli

Re: [DISCUSS] Pulsar release

2017-07-24 Thread Dave Fisher
Hi - > On Jul 21, 2017, at 4:23 PM, Matteo Merli wrote: > > (Starting a new thread to detach from the general website discussion) > > I think that it would be good to try to release a new Pulsar version ASAP, > following the Apache release process and requirements. > > That would take the proj

[GitHub] merlimat commented on issue #592: Added script to sign release artifacts

2017-07-24 Thread git
merlimat commented on issue #592: Added script to sign release artifacts URL: https://github.com/apache/incubator-pulsar/pull/592#issuecomment-317502032 @rdhabalia It would be used when creating the release. I'm adding a wiki page to describe the process. It's still a work in progress at th

[GitHub] rdhabalia commented on issue #592: Added script to sign release artifacts

2017-07-24 Thread git
rdhabalia commented on issue #592: Added script to sign release artifacts URL: https://github.com/apache/incubator-pulsar/pull/592#issuecomment-317500875 just a quick question : where are we going to use this file? This is an

[GitHub] merlimat opened a new pull request #592: Added script to sign release artifacts

2017-07-24 Thread git
merlimat opened a new pull request #592: Added script to sign release artifacts URL: https://github.com/apache/incubator-pulsar/pull/592 ### Motivation Added tools to create signatures and checksum during the release process. Instructions on how to use it, will be added on the

[GitHub] lucperkins commented on issue #591: Fixed references to Yahoo pages

2017-07-24 Thread git
lucperkins commented on issue #591: Fixed references to Yahoo pages URL: https://github.com/apache/incubator-pulsar/pull/591#issuecomment-317499823 ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat commented on issue #591: Fixed references to Yahoo pages

2017-07-24 Thread git
merlimat commented on issue #591: Fixed references to Yahoo pages URL: https://github.com/apache/incubator-pulsar/pull/591#issuecomment-317499287 cc/ @lucperkins This is an automated message from the Apache Git Service. To r

[GitHub] merlimat opened a new pull request #591: Fixed references to Yahoo pages

2017-07-24 Thread git
merlimat opened a new pull request #591: Fixed references to Yahoo pages URL: https://github.com/apache/incubator-pulsar/pull/591 ### Motivation Fixed links to `yahoo/pulsar` github repo and examples with `com.yahoo.pulsar` package names. Added disclaimer in download page to n

[GitHub] merlimat commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
merlimat commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590#issuecomment-317485639 > Are we controlling the logger object destruction? Yeah, that's my suspicion as well. @jai1 Have y

[GitHub] saandrews commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
saandrews commented on issue #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590#issuecomment-317480876 Are we controlling the logger object destruction? --

[GitHub] jai1 opened a new pull request #590: CPP Client - removed log statement from ClientImpl Destructor

2017-07-24 Thread git
jai1 opened a new pull request #590: CPP Client - removed log statement from ClientImpl Destructor URL: https://github.com/apache/incubator-pulsar/pull/590 As a part of #485 I had added this log statement in the destructor of ClientImpl, this causes core dump due to heap corruption in few