merlimat commented on a change in pull request #538: Make broker configurable
to own non-persistent topic
URL: https://github.com/apache/incubator-pulsar/pull/538#discussion_r129182034
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LoadReport.java
##########
@@ -42,6 +42,9 @@
private final String webServiceUrlTls;
private final String pulsarServiceUrl;
private final String pulsarServiceUrlTls;
+ private boolean enablePersistentTopics=true;
Review comment:
Minor and probably a bit of nit-picking. Here it should be referring on
wether the feature is "enabled" or "disabled", rather than be imperative
("enable").
Should we rename to `persistentTopicsEnabled`, `nonPersistentTopicsEnabled`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
