Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread PengHui Li
+1 (binding) Regards, Penghui On Thu, Jun 6, 2024 at 3:25 PM thetumbled wrote: > The vote is approved with 3 binding votes and close now. > Votes: > - Kai Wang(non-binding) > - Yunze Xu(binding) > - guo jiwei(binding) > - Yubiao Feng(binding) > > Thank you all for verifying and voting! > Wenzhi

Re: [VOTE] PIP-355: Enhancing Broker-Level Metrics for Pulsar

2024-06-10 Thread PengHui Li
+1 (binding) Regards, Penghui On Sat, Jun 1, 2024 at 5:05 AM Dragos Misca wrote: > +1 non-binding > > Thank you, > Dragos > > > On May 30, 2024, at 5:47 PM, Hang Chen wrote: > > > > Hi, all > > > > I would like to start the voting thread for PIP-355: Enhancing > > Broker-Level Metrics for Puls

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.6 Candidate 1

2024-06-17 Thread PengHui Li
+1 (binding) - Verified checksum - Verified signatures Thanks, Penghui On Sun, Jun 16, 2024 at 8:29 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source > - Verified the binaries > > Thanks, > Yunze > > On Sun, Jun 16, 2024 at 3:23 AM Chris Bono wrote

Re: [VOTE] PIP-366: Support to specify different config for Configuration and Local Metadata Store

2024-07-22 Thread PengHui Li
+1 (binding) Thanks for driving the proposal. Regards, Penghui On Sun, Jul 21, 2024 at 6:46 PM Kai Wang wrote: > Hi all, I want to start a vote on PIP-366: Support to specify different > config for Configuration and Local Metadata Store. > > You can find the proposal at https://github.com/apac

Re: [VOTE] Release Apache Pulsar 3.3.1 based on 3.3.1-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 3

Re: [VOTE] Release Apache Pulsar 3.2.4 based on 3.2.4-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] Release Apache Pulsar 3.0.6 based on 3.0.6-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-12 Thread PengHui Li
Hi Yubiao, Thanks for driving the improvements to Pulsar. The motivation and the high-level solution look good to me. I just left some comments on the proposal for the details. The major idea for resolving this issue is to separate the user-facing topic auto-creation and topic auto-creation by da

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.7 Candidate 1

2024-08-14 Thread PengHui Li
+1 (binding) - Checked the signature - Verified the checksum Regards, Penghui On Wed, Aug 14, 2024 at 10:09 AM Lari Hotari wrote: > +1 (binding) > > Validated source artifacts > - checked sha512 checksum > - checked signature > > Validated binaries > - ran sample app > > -Lari > > On 2024/08/1

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-15 Thread PengHui Li
+1 (binding) Sorry for the late response on the mailing list. Regards, Penghui On Thu, Aug 15, 2024 at 7:44 PM Yubiao Feng wrote: > The vote is approved with 4 binding votes and close now. > > Votes: > - Hang Chen (binding) > - Jiwei Guo (binding) > - Lari Hotari (bindi

Re: [DISCUSS] PIP-376 Make topic policies service pluggable

2024-09-03 Thread PengHui Li
Thanks for driving the proposal. I support this proposal and left a few comments on the PR Regards, Penghui On Tue, Sep 3, 2024 at 8:54 AM Enrico Olivelli wrote: > Nice write up ! > > I generally support this proposal, we should have clearer APIs for the > components we want to allow users to

Re: [VOTE] PIP-376 Make topic policies pluggable

2024-09-04 Thread PengHui Li
+1 Thanks Penghui On Wed, Sep 4, 2024 at 20:14 Lari Hotari wrote: > +1 (binding) > > -Lari > > On 2024/09/05 02:53:22 Yunze Xu wrote: > > Hi all, > > > > I want to start a vote on PIP-376 Make topic policies pluggable. > > > > Proposal link: https://github.com/streamnative/pulsar/pull/307 > > D

Re: [VOTE] PIP-374: Visibility of messages in receiverQueue for the consumers

2024-09-05 Thread PengHui Li
+1 binding Regards Penghui On Wed, Sep 4, 2024 at 19:55 Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Sep 4, 2024 at 2:15 PM Baodi Shi wrote: > > > > +1(binding) > > > > Thanks, > > Baodi Shi > > > > Bhat, Vinay 于2024年9月4日周三 12:22写道: > > > > > > Hi All, > > > > > > I want to

Re: [DISCUSS] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering

2024-09-15 Thread PengHui Li
Hi Lari, I recommend creating a new implementation rather than directly replacing the existing one. This approach aligns with how we’ve handled several proposals in the past and allows us to maintain stability while introducing improvements - PIP-192: New Pulsar Broker Load Balancer - PIP-195: Ne

Re: [VOTE] PIP-378 Add ServiceUnitStateTableView abstraction (ExtensibleLoadMangerImpl only)

2024-09-16 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Sep 16, 2024 at 8:17 AM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Mon, Sep 16, 2024 at 3:06 AM Lari Hotari wrote: > > > > +1 (binding) > > > > -Lari > > > > On Sun, 15 Sept 2024 at 21:34, Heesung Sohn wrote: > > > > > > Hi all, > > > > > >

Re: [VOTE] PIP-196 Segmented transaction buffer snapshot

2022-09-08 Thread PengHui Li
+1(binding) I have done the review on gdoc And please also update the github issue(PIP). Thanks, Penghui On Fri, Sep 9, 2022 at 9:31 AM 丛搏 wrote: > Hi, Xiangying > +1(non-binding) > > This PIP overall LGTM! It solves the problem of snapshots not being > able to scale. > We can make some optim

Re: [DISSCUSS] Code coverage report for PRs to master

2022-09-10 Thread PengHui Li
Hi Lin, Thanks for starting this discussion. First, I support having code coverage repo for the PR which will provide the initial impressions of the test coverage to reviewers. Although the code coverage report can produce distorted results, the report is not the supreme indicator, just an auxili

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-16 Thread PengHui Li
Thanks, Lari After I go through all the comments here. Do we really need a new label? It looks like if a committer thinks we should trigger the CI in the Pulsar repo - Passed in the fork repo - No request change for this PR. - ... Just run the "/pulsarbot ready-to-test" or "/pulsarbot trigger-c

Re: [VOTE] PIP-209: Separate C++/Python clients to own repositories

2022-09-28 Thread PengHui Li
+1 (binding) Penghui On Tue, Sep 27, 2022 at 5:17 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Mar 27 Set 2022, 11:13 Max Xu ha scritto: > > > +1 (non-binding) > > > > Best, > > Max Xu > > > > > > On Tue, Sep 27, 2022 at 4:50 PM Anon Hxy wrote: > > > > > +1 (non binding) > > > >

Re: [VOTE] Pulsar Client Go Release 0.9.0 Candidate 2

2022-09-29 Thread PengHui Li
+1 (binding) - build from the source code - test the produce and consume Penghui On Thu, Sep 29, 2022 at 2:43 PM Guangning E wrote: > +1(non-binding) > - Check sha 512 value for source code > - Check go build producer example > > Thanks, > Guangning > > r...@apache.org 于2022年9月29日周四 14:35写道:

Re: [DISCUSS] Release Pulsar Client C++ 3.0.0

2022-10-07 Thread PengHui Li
+1 Regards, Penghui On Fri, Oct 7, 2022 at 11:34 PM tison wrote: > +1 cool! > > Best, > tison. > > > Baodi Shi 于2022年10月7日周五 23:31写道: > > > +1 > > > > Thanks, > > Baodi Shi > > > > > 在 2022年10月7日,22:00,Max Xu 写道: > > > > > > +1 > > > Thanks, Matteo. It's a great work! > > > > > > Best, > > >

Re: [ANNOUNCE] New Committer: Qiang Huang

2022-10-16 Thread PengHui Li
Congrats, Qiang Huang. Regards, Penghui On Sat, Oct 15, 2022 at 11:53 PM lordcheng10 wrote: > Congratulations Qiang Huang > > r...@apache.org 于2022年10月14日周五 17:02写道: > > > Congratulations Qiang Huang > > > > -- > > Thanks > > XiaolongRan > > > > Nicolò Boschi 于2022年10月14日周五 15:23写道: > > > > >

Re: [ANNOUNCE] Haiting Jiang as a new PMC member in Apache Pulsar

2022-10-20 Thread PengHui Li
Congratulations, Haiting! Best, Penghui On Thu, Oct 20, 2022 at 9:53 AM Jun Ma wrote: > Congratulations, Haiting! > > > Best, > Jun > > From: Yunze Xu > Sent: Wednesday, October 19, 2022 23:23 > To: dev@pulsar.apache.org > Subject: Re: [ANNOUNCE] Haiting Jiang

Re: PIP-Java Client support to Cumulative Acknowledge messages for multiple partitions or topics

2022-10-20 Thread PengHui Li
> while (true) { Messages messages = consumer.batchReceive(); Message finalMessage = null; for (Message message : messages) { process(message); finalMessage = message; } if (finalMessage != null) { consumer.acknowledgeCumulativeAsync(finalMessage); }

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-20 Thread PengHui Li
Hi Heesung. Is it possible to send the promoted value to the topic again to achieve eventual consistency? For example: We have 3 brokers, broker-a, broker-b, and broker-c The message for leader election could be "own: broker-b", "own: broker-c", "own: broker-a" The broker-b will win in the end.

Re: [VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-23 Thread PengHui Li
+1 (binding) Thanks, Penghui On Sat, Oct 22, 2022 at 4:03 AM Dave Fisher wrote: > +1 (binding) > > > On Oct 20, 2022, at 11:06 PM, Michael Marshall > wrote: > > > > Bump. In my opinion, this is a bug that we need to fix before any new > > releases. It is only a PIP because fixing the bug requi

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-10-23 Thread PengHui Li
I support the motivation. When I read the document of Prometheus I see "A label with an empty label value is considered equivalent to a label that does not exist." [0] Can we just keep the value of the topic and namespace label empty? And here is a blog that introduced how to deal with the empty l

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-23 Thread PengHui Li
key) broker back to the topic. So that the table view will always show the first value of the key before the topic compaction or after the topic compaction. Thanks, Penghui On Sat, Oct 22, 2022 at 12:23 AM Heesung Sohn wrote: > Hi Penghui, > > I put my answers inline. > > On Thu, O

Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-24 Thread PengHui Li
+1 (binding) - Verified the signatures - Build from the source (osx 12.6) Thanks, Penghui On Mon, Oct 24, 2022 at 10:53 PM Yunze Xu wrote: > +1 (non-bindings) > > * verify checksum and signatures > * build from source (Ubuntu 20.04 x86_64) > * basic e2e tests with libraries built from source >

Re: [DISCUSS] PIP-218: Consumer batchReceive() single partition every receive

2022-10-25 Thread PengHui Li
+1 Penghui On Tue, Oct 25, 2022 at 12:25 PM 丛搏 wrote: > Hi, pulsar community: > > I start a PIP about `User-friendly acknowledgeCumulative API on a > partitioned topic or multi-topics` > > discuss thread: > https://lists.apache.org/thread/30rwksz4gmvgspkgcfsk708sgb1n7vbo > https://lists.apache.

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-25 Thread PengHui Li
opics. > > pulsar-admin topicPolicies set-compaction-strategy options > pulsar-admin topicPolicies get-compaction-strategy options > > Regards, > Heesung > > > > On Mon, Oct 24, 2022 at 1:41 PM Heesung Sohn > > wrote: > > > Hi, please find my ans

Re: [VOTE] PIP-218: Consumer batchReceive() single partition every receive

2022-10-28 Thread PengHui Li
+1 (binding) Thanks, Penghui On Fri, Oct 28, 2022 at 1:32 PM Haiting Jiang wrote: > +1 (binding) > > Thanks, > Haiting > > On Fri, Oct 28, 2022 at 10:43 AM Yunze Xu > wrote: > > > > +1 (non-binding) > > > > Thanks, > > Yunze > > > > On Thu, Oct 27, 2022 at 9:14 PM 丛搏 wrote: > > > > > > Hi, pu

Re: [DISCUSS] PIP-217: LoadShedding Strategy Improment

2022-10-30 Thread Penghui Li
Hi, It looks like we move the bundle from one broker to another broker but doesn't move the historical load data of this bundle. I suppose this is the main cause of the problem. Thanks, Penghui On 2022/10/24 17:46:21 Heesung Sohn wrote: > Hi, > > Currently, the historical score is based on ex

Re: Releasing current master as Pulsar 2.11.0 ?

2022-10-31 Thread PengHui Li
Releasing from the master branch will bring more uncertainty, no? We have fixed many regressions that were introduced to branch-2.11. If we cut a new branch-2.11 based on the master branch. Maybe new regressions will happen again. This may make us wait another month to have a 2.11.0 release. IMO,

Re: Releasing current master as Pulsar 2.11.0 ?

2022-10-31 Thread PengHui Li
ke that problem > worse. As it is, we already need to discuss EOL for 2.7 and 2.8. > > Thanks, > Michael > > On Mon, Oct 31, 2022 at 7:55 PM PengHui Li wrote: > > > Releasing from the master branch will bring more uncertainty, no? > > We have fixed many regressions th

Re: [DISCUSS] Release Pulsar 2.9.4

2022-11-02 Thread PengHui Li
+1 Thanks, Penghui > On Nov 3, 2022, at 14:01, 丛搏 wrote: > > Hello, Pulsar community: > > I'd like to propose releasing Apache Pulsar 2.9.4. It's been about > three months since 2.9.3 was released. > > There are 123 PRs [0] needed to cherry-pick in branch-2.9. I will > cherry-pick these PRs f

Re: [VOTE] PIP-219: Support full scan and trim ledger

2022-11-05 Thread PengHui Li
+1 Penghui linlin 于2022年11月1日 周二22:28写道: > Hi folks, > > I'd like to start a vote for the PIP-219: Support full scan and trim ledger > ( > https://github.com/apache/pulsar/issues/18128) > > The discussion can be found here: > https://lists.apache.org/thread/wy8sqs2fdmw3kcdfos7t1ztpccfdmv72 > > B

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-11-07 Thread PengHui Li
r="my-cluster"} 0 >> >> The motivation for those metrics is provided here [0], though I'm not >> sure it is good motivation. >> >> Thanks, >> Michael >> >> [0] >> https://github.com/apache/pulsar/blob/6d6665e296e6714801048dee1292

Re: [DISCUSSION] Redesign the MessageId interface

2022-11-13 Thread PengHui Li
Great discussion! I agree with the conclusions! IMO, we should not encourage users to touch the different implementations of the MessageId. Instead, we should provide a `MesssageIdUtils` in the client library(not the interface) with annotations `@InterfaceAudience.Public @InterfaceStability.Stable

[ANNOUNCE] New Committer: Lin Chen

2022-11-13 Thread PengHui Li
The Project Management Committee (PMC) for Apache Pulsar has invited Lin Chen (https://github.com/lordcheng10) to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submissi

Re: [Vote] PIP-215: Configurable TopicCompactionStrategy for StrategicTwoPhaseCompactor and TableView

2022-11-14 Thread PengHui Li
+1 Thanks, Penghui On Wed, Nov 9, 2022 at 12:52 AM Heesung Sohn wrote: > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18099 > > Thank you, > -Heesung >

Re: [Vote] PIP-220 TransferShedder (only for PIP-192 New Broker Load Balancer)

2022-11-17 Thread PengHui Li
+1 Penghui On Fri, Nov 18, 2022 at 1:40 AM Matteo Merli wrote: > +1 > > > -- > Matteo Merli > > > On Tue, Nov 15, 2022 at 3:20 PM Heesung Sohn > wrote: > > > > Dear Pulsar Community, > > > > Please review and vote on this PIP. > > > > PIP link: https://github.com/apache/pulsar/issues/18215 >

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread PengHui Li
+1 Penghui On Fri, Nov 18, 2022 at 12:51 AM Jiuming Tao wrote: > My understanding is that the PIP will add a generic mechanism to track > commands ("pulsar_broker_command_execution_latency" with label > "code”) > > > pulsar_broker_command_execution_latency with `command` label to track the > c

Re: Data quality problem

2022-11-20 Thread PengHui Li
Hi, Devin Thanks for raising the great discussion. It looks like the salient point is that Pulsar doesn't support native JSON schema. Instead, the schema is defined in the Avro standard but serialized to JSON format.JSON Schema combines aspects of type-based and rule-based. As this article[1] said

Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread PengHui Li
Congrats! Cong Thanks, Penghui > On Nov 21, 2022, at 13:57, Zixuan Liu wrote: > > Congrats! Cong > > Best Regards, > Zixuan > > houxiaoyu 于2022年11月21日周一 12:24写道: > >> Congrats! Cong >> >> Best, >> Xiaoyu Hou >> >> Haiting Jiang 于2022年11月21日周一 12:10写道: >> >>> The Project Management Commi

Re: [VOTE] PIP-211: Introduce offload throttling

2022-11-22 Thread PengHui Li
+1 binding Penghui On Tue, Nov 22, 2022 at 6:03 PM Enrico Olivelli wrote: > +1 binding > > Enrico > > Il Mar 22 Nov 2022, 09:42 Haiting Jiang ha > scritto: > > > +1 binding > > > > Thanks, > > Haiting > > > > On Mon, Nov 21, 2022 at 7:03 PM Jiuming Tao > > wrote: > > > > > > Dear Pulsar Commu

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread PengHui Li
Hi, Jiuming Thanks for starting the proposal. We'd better add an option to enable or disable the endpoint-level metrics. And keep it as disabled as default. I noticed the existing jetty metrics are based on `org.eclipse.jetty.server.handler.StatisticsHandler`. Can we just have a new StatisticsHa

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-22 Thread PengHui Li
Hi, Bo Thanks for starting the discussion. I have no idea about the initial motivation for supporting message redelivery for Failover or Exclusive subscription. The redelivered messages will go to the same consumer under a single active consumer subscription mode. Or maybe it is only designed fo

Re: [DISCUSS] Release Pulsar Python Client 3.0.0

2022-11-23 Thread PengHui Li
+1 Penghui > On Nov 23, 2022, at 21:38, Enrico Olivelli wrote: > > +1 > thanks > > Enrico > > Il giorno mer 23 nov 2022 alle ore 13:53 Yunze Xu > ha scritto: >> >> Hi all, >> >> It has been about 2 months since the official Python client was moved >> out of the main repo. I'm going to rele

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread PengHui Li
Hi Bo, Thanks for raising the discussion. +1 for re-cherry-pick the commits. The misleading commit logs will confuse users. Regards, Penghui On Fri, Nov 25, 2022 at 12:29 PM 丛搏 wrote: > Hi, pulsar community, > > I am sorry for that, there is no commit to execute cherry-pick > --continue, resu

Re: [DISCUSS] Release API docs only for major release (minor version bump)

2022-11-27 Thread PengHui Li
+1 Penghui > On Nov 26, 2022, at 19:05, Enrico Olivelli wrote: > > +1 > > Thanks > Enrico > > Il Sab 26 Nov 2022, 10:02 tison ha scritto: > >> Thanks for your feedback! I'll create a tracking issue and start working on >> subtasks the next week :) >> >> Best, >> tison. >> >> >> Haiting J

Re: [DISCUSS] Close the connection quickly after authorization failure

2022-11-27 Thread PengHui Li
> I would like to discuss whether to disconnect the broker and the client after authorization failure. I don't think we should close the connection for authorization failure. A connection can be used across multiple topics. Irrationality is no accessibility of a topic will disconnect producers and

Re: [DISCUSS] Release Pulsar 2.10.3

2022-11-28 Thread PengHui Li
+1 Thanks, Penghui > On Nov 28, 2022, at 17:48, Xiangying Meng wrote: > > Hello, Pulsar community: > > I'd like to propose releasing Apache Pulsar 2.10.3. It's been about one > month since 2.10.2 was released. > > There are 93 PRs [0] needed to cherry-pick in branch-2.10. I will > cherry-pick

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-29 Thread PengHui Li
commit messages. > > > > I also do not think we should allow force pushing to release branches > > or to master branch in the future. In my opinion, the git history > > should be immutable. > > > > Thanks, > > Michael > > > > > > On Fri

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-29 Thread PengHui Li
t; On Tue, Nov 29, 2022 at 3:41 AM PengHui Li wrote: > > > > It's not only two commits > > There are more than 10 commits with meaningless commit messages. > > Please check the commit logs > > https://github.com/apache/pulsar/tree/branch-2.9-backup > > &

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-02 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source - Start standalone - Done some simple performance test( publish, consume, and drain backlog) - Checked function - Checked Cassandra connector - Checked stateful function (failed with rocksdb metadata service) - Checked stateful function with

Re: [VOTE] Pulsar Client C++ Release 3.1.0 Candidate 3

2022-12-05 Thread PengHui Li
+1 binding - Verified the signatures - Verified the Linux platform follows the documentation [0] - RPM - DEB - APK [0] https://github.com/BewareMyPower/pulsar-client-cpp-demo Thanks, Penghui On Fri, Dec 2, 2022 at 2:06 PM Matteo Merli wrote: > +1 binding. > > Checked: > * Sour

Re: [DISCUSS] Transactions isolation design

2022-12-05 Thread PengHui Li
Thanks for starting the discussion. One transaction is allowed to work with multiple topics from multiple tenants/namespaces. And there are some real cases of injecting data from multiple tenants and publishing the calculated result to one or many topics under exactly-once semantics. But I agree

Re: [Vote] PIP-223: Add metrics for all Rest Endpoints

2022-12-05 Thread PengHui Li
+1 binding Penghui > On Dec 6, 2022, at 09:34, mattisonc...@gmail.com wrote: > > +1 > > Best, > Mattison > On Nov 28, 2022, 16:47 +0800, Jiuming Tao , > wrote: >> Dear Pulsar Community, >> >> Please review and vote on this PIP. >> >> PIP link: https://github.com/apache/pulsar/issues/18560 >>

Re: [DISCUSS] Remove restful producer component

2022-12-06 Thread PengHui Li
+1 And we should also remove the documentation of this part. Penghui > On Dec 6, 2022, at 18:36, mattisonc...@gmail.com wrote: > > > Hello, everyone. > > I'd like to start the discussion about `Remove restful producer component`. > The Github repository path is here[1]. > > As discussed bef

[DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-06 Thread PengHui Li
Hi all, I would like to start a discussion about requiring a proposal for Admin API/CLI and metrics changes. Here are some recent examples that changed the Admin API but without proposals. I just checked the commit logs. Maybe some have a proposal. Just forgot to add the proposal link to the PR.

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-06 Thread PengHui Li
cument to describe these > metrics? I think the metrics body should be documented well to avoid > breaking changes. Some external applications might parse the metrics > according to a specific structure. > > Thanks, > Yunze > > On Wed, Dec 7, 2022 at 11:38 AM PengHui Li wrote

Re: [DISCUSS] How to handle broker public API changes

2022-12-06 Thread PengHui Li
Hi mattison Could you please share more details about how the change breaks the broker public API? It will help us to understand the compatibility issue. Thanks, Penghui > On Dec 7, 2022, at 12:39, mattisonc...@gmail.com wrote: > > Hi, All > > Recently, I realised we don't have any rules for

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-06 Thread PengHui Li
Hi Zixuan, If it only affects standalone. I think it’s ok. For standalone, multiple bundles help nothing, right? No rebalance will happen for a standalone. Thanks, Penghui > On Dec 7, 2022, at 11:23, Yunze Xu wrote: > > The change of a default value is acceptable in a major release. But > sinc

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-07 Thread PengHui Li
es > and doc-required are checked both are checked with textual information > provided? > > Best, > Dave > > > > Thanks, > > Yunze > > > >> On Wed, Dec 7, 2022 at 11:48 AM PengHui Li wrote: > >> > >> Hi Yunze, > >>

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread PengHui Li
it’s ok. > > Right. > > > For standalone, multiple bundles help nothing, right? > > I'm wondering whether affecting the resource quota. Could you confirm that? > > Thanks, > Zixuan > > PengHui Li 于2022年12月7日周三 12:53写道: > > > Hi Zixuan, > > >

Re: [DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread PengHui Li
Hi, Jie One option is you can try to call consumer.pause() first. Then the consumer will not increase flow permits. No new messages will be dispatched to this consumer. And you can continue to receive messages from the buffer of the consumer. After all cached messages consumed. You can close the

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread PengHui Li
dk8 but the image uses jdk17 > and > > > this > > > > > may be very annoying if pulsar-perf is not usable within the > official > > > > > docker image. > > > > > > > > > > btw I've send out the fix: > ht

Re: [VOTE] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-14 Thread PengHui Li
+1 (binding) - Penghui On Sun, Dec 11, 2022 at 6:36 AM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Ven 9 Dic 2022, 10:41 Jiaqi Shen ha scritto: > > > +1(non-binding) > > > > Thanks, > > Jiaqi Shen > > > > > > 于2022年12月5日周一 15:23写道: > > > > > +1(non-binding) > > > > > > Best, > > >

Re: [VOTE] Pulsar Release 2.9.4 Candidate 3

2022-12-14 Thread PengHui Li
+1 (binding) - Checked the signature - Start standalone - Publish and consume messages - Verified Function and State Function - Verified Cassandra connector - Build from the source package Thanks, Penghui On Tue, Dec 13, 2022 at 7:49 PM 丛搏 wrote: > This is the third release candidate for Apach

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-16 Thread PengHui Li
nks, > Haiting > > On Wed, Dec 7, 2022 at 4:07 PM PengHui Li wrote: > > > > > I agree a proposal would be better before adding a PR. But the > > document part must be a part of such a proposal. > > > > Make sense. It looks like we should have a checklist for

Re: [DISCUSS] forbid user to upload `BYTES` schema

2022-12-18 Thread PengHui Li
+1 We should keep the behavior of the Admin API consistent with the Pulsar Client. > I think we should think about why we can not add a new schema of BYTES. > The users use the byte schema to send or consume messages. But the schema > registry has never stored the BYTES schema and we always need

Re: [DISCUSSION] Any idea about simplify the configuration file?

2022-12-18 Thread PengHui Li
> I am not sure that we need this file, we can use the documentation website to advertise about all the possibilities. +1. I also don't think we need another file for all the broker configurations. We can just provide a page with all the possibilities. > For example, the IDE code completion works

Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-18 Thread PengHui Li
I agree with the motivation. Just some minor suggestions: Is AdvancedMessageId or MessageIdAdv better for this case to replace PulsarApiMessageId? It looks like LedgerHandleAdv to LedgerHandle in the bookkeeper. > We have to deprecated the BatchMessageAcker, which is just a wrapper of a BitSet a

Re: [VOTE] Pulsar Release 2.11.0 Candidate-3

2022-12-18 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source - Start standalone with zookeeper - Done some simple performance test( publish, consume, and drain backlog) - Checked function - Checked Cassandra connector - Checked stateful function Thanks, Penghui On Sun, Dec 18, 2022 at 8:33 PM 丛搏 wr

Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-18 Thread PengHui Li
also makes code more > complicated, e.g. the `getOriginalBatchSize` and `getBatchSize` > methods in `BatchMessageIdImpl`. > > Thanks, > Yunze > > On Mon, Dec 19, 2022 at 9:35 AM PengHui Li wrote: > > > > I agree with the motivation. > > > > Just so

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-19 Thread PengHui Li
anges. but It is > difficult for us to judge whether a PR is a bug fix or needs PIP or > doc/required through automatic detection. We can standardize the > committer review process and increase the description of the review > document, which may achieve better results. > > T

Re: [DISCUSS] PIP-231: Add metric for topic load failed

2022-12-19 Thread PengHui Li
+1 Penghui On Mon, Dec 19, 2022 at 4:20 PM Jiuming Tao wrote: > Hello pulsar community, > > I've opened `PIP-231: Add metric for topic load failed` to discuss. > > Motivation: > Currently, we have topic_load_times > > metri

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-19 Thread PengHui Li
+1 I support moving them to the website repo. Thanks, Penghui On Mon, Dec 19, 2022 at 12:04 PM Yunze Xu wrote: > +1. The most significant point to me is that we can preview all the > content of the website without synchronizing contents from the > apache/pulsar repo. > > Thanks, > Yunze > > On

[DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-19 Thread PengHui Li
Hi all, I noticed the Java Client (I haven't checked other clients) uses 1 IO thread and 1 listener thread by default. It will require users to update the thread configuration if they have multiple cores and desired high throughput. Here is the example that we change to 16 IO threads in openmessa

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2022-12-20 Thread PengHui Li
+1 Thanks, Penghui On Mon, Dec 19, 2022 at 6:19 PM wrote: > > Hi, All > > I would like to introduce a new library oshi[1] to help Apache Pulsar > sensory OS resources. It can help us to get away from the complex file > manipulation and cross-platform compatibility issues in some operating > sys

Re: [VOTE] Pulsar Client Python Release 3.0.0 Candidate 3

2022-12-21 Thread PengHui Li
+1 - Checked the signature - Install the python .whl file (pip3 install pulsar_client-3.0.0-cp38-cp38-macosx_10_15_universal2.whl) on macOS 13.0.1 (22A400) - Start the standalone (build from the master branch) - Start consumer (python3 ./examples/consumer.py) - Start producer (python3 ./examples/p

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-21 Thread PengHui Li
l executor of the client > - scheduled executor of the client > - HTTP client io thread pool of pulsar admin client > > see: https://github.com/apache/pulsar/pull/19020 > > Should we provide other APIs to configure these three thread pools? > > Thanks > Yubiao > >

Re: [DISCUSS] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-21 Thread PengHui Li
> In short, `seek(msgId)` will call `seek(TopicMessageId)` if `msgId` is a `TopicMessageId`. Does it look like we don't need to add the following new APIs? ``` void seek(TopicMessageId topicMessageId) throws PulsarClientException; CompletableFuture seekAsync(TopicMessageId topicMessageId); ``` U

Re: [DISCUSS] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-21 Thread PengHui Li
lsar. Thanks, Penghui On Thu, Dec 22, 2022 at 9:48 AM PengHui Li wrote: > > In short, `seek(msgId)` will call `seek(TopicMessageId)` if `msgId` is > a `TopicMessageId`. > > Does it look like we don't need to add the following new APIs? > > ``` > void seek(TopicMessageId to

Re: [VOTE] PIP-228: Refactor the information architecture of Pulsar client docs

2022-12-21 Thread PengHui Li
+1 (binding) Thanks, Penghui On Wed, Dec 21, 2022 at 10:18 AM 丛搏 wrote: > +1 (non-binding) > > Thanks, > Bo > > Yu 于2022年12月21日周三 09:51写道: > > > > +1 > > > > On Tue, Dec 20, 2022 at 3:12 PM Yunze Xu > > wrote: > > > > > +1 (non-binding) > > > > > > Thanks, > > > Yunze > > > > > > On Tue, Dec

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread PengHui Li
Is it better to point to user@ list? I noticed that most discussions are user-facing issues(Requirements, Questions) Thanks, Penghui On Fri, Dec 23, 2022 at 10:18 AM Yunze Xu wrote: > +1 > > Thanks, > Yunze > > On Fri, Dec 23, 2022 at 6:04 AM Michael Marshall > wrote: > > > > Hello Pulsar Comm

Re: [VOTE] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-22 Thread PengHui Li
+1(binding) Thanks, Penghui On Fri, Dec 23, 2022 at 10:31 AM 丛搏 wrote: > +1 (non-binding) > > Thanks, > Bo > > Yunze Xu 于2022年12月22日周四 20:34写道: > > > > Hi all, > > > > I'm starting the VOTE for PIP-229: Add a common interface to get > > fields of MessageIdData: https://github.com/apache/pulsar

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-25 Thread PengHui Li
nks, > Michael > > > > > On Fri, Dec 23, 2022 at 12:44 AM 丛搏 wrote: >> >> +1 for pointing to the user list. >> >> Thanks, >> Bo >> >> Dave Fisher 于2022年12月23日周五 12:48写道: >>> >>> >>> >>> Sent

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-26 Thread PengHui Li
case I think, so this change looks good to me. > > > > > > > > > > Thanks, > > > > > Xiaoyu Hou > > > > > > > > > > 于2022年12月20日周二 12:25写道: > > > > > > > > > > > +1 > > > &g

Re: [VOTE] Pulsar Release 2.11.0 Candidate-4

2022-12-26 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source - Checked license - Start standalone with zookeeper - Done some simple performance test( publish, consume, and drain backlog) - Checked function - Checked Cassandra connector - Checked stateful function Thanks, Penghui On Tue, Dec 27, 202

Re: [Vote] PIP-231: Add metric for topic load failed

2022-12-27 Thread PengHui Li
+1 Thanks, Penghui > On Dec 27, 2022, at 16:27, Jiuming Tao wrote: > > Hello pulsar community, > > I'm starting the VOTE for PIP-231: Add metric for topic load failed. > > Motivation: > Currently, we have a `topic_load_times` metric to track how long a topic > load succeeds. > But when loadin

[DISCUSS] PIP-234: Support using shared thread pool across multiple Pulsar client instance

2022-12-27 Thread PengHui Li
Hi all, As discussed at https://lists.apache.org/thread/5obfm17g58n3dnbzyxg57vokgmwyp6hx I have created this proposal to support shared thread pool across multiple client instances Here is the proposal link https://github.com/apache/pulsar/issues/19074 Please help take a look, and look forward to

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-27 Thread PengHui Li
I have created a proposal for sharing the thread pool across client instances. Here is the PIP discussion thread https://lists.apache.org/thread/5jw06hqlmwnrgvbn9lfom1vkwhwqwwd4 Thanks for all your suggestions -- Penghui On Mon, Dec 26, 2022 at 9:39 PM PengHui Li wrote: > > I think t

Re: [DISCUSS] PIP-234: Support using shared thread pool across multiple Pulsar client instance

2022-12-27 Thread PengHui Li
rpose. > > If we require users to deal with all the possible sharable resources > then we have a few risks: > - people can "forget" to share some resources > - upgrading the client may lead to not taking into account some new > "shareable" resources > &g

Re: [VOTE] Pulsar Release 2.10.3 Candidate 1

2022-12-27 Thread PengHui Li
+1 (binding) OS: macOS 13.0.1 (22A400) maven: 3.8.6 JDK: java version "11.0.7" 2020-04-14 LTS - Checked the signature - Build from the source package - Checked LICENSE - Start standalone - Publish and consume messages - Verified Function and State Function - Verified Cassandra connector Thanks,

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 2

2022-12-28 Thread PengHui Li
+1 (binding) Verify following the steps from https://github.com/RobertIndie/pulsar-client-node-validation - Start standalone (master branch) - Start consumer (node ./examples/consumer.js) - Start producer (node ./examples/producer.js) - The consumer can receive the messages Regards, Penghui On

Re: [DISCUSS] PIP-234: Support using shared thread pool across multiple Pulsar client instance

2022-12-28 Thread PengHui Li
reads options. Thanks, Penghui On Tue, Dec 27, 2022 at 8:35 PM PengHui Li wrote: > Ah, got it. > > It's a good idea for users to be aware of all shared resources. > I will change the proposal as per your suggestion > > Thanks, > Penghui > > On Tue, Dec 27, 202

Re: [ANNOUNCE] Yunze Xu as a new PMC member in Apache Pulsar

2022-12-29 Thread PengHui Li
Congrats, Yunze Thanks, Penghui > On Dec 30, 2022, at 09:00, Yu wrote: > > Congrats! Yunze > > On Thu, Dec 29, 2022 at 11:00 PM Zike Yang wrote: > >> Congratulations! Yunze >> >> BR. >> Zike Yang >> >> On Thu, Dec 29, 2022 at 10:42 PM Zixuan Liu wrote: >>> >>> Congrats! Yunze >>> >>> Be

Re: [VOTE] Pulsar Release 2.11.0 Candidate-5

2023-01-03 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source - Checked license(server and shell) - Start standalone with zookeeper - Checked function - Checked Cassandra connector - Checked stateful function - Checked the Pulsar SQL Thanks, Penghui On Mon, Jan 2, 2023 at 8:01 PM guo jiwei wrote: >

<    3   4   5   6   7   8   9   10   11   >