Hi, Jiuming Thanks for starting the proposal.
We'd better add an option to enable or disable the endpoint-level metrics. And keep it as disabled as default. I noticed the existing jetty metrics are based on `org.eclipse.jetty.server.handler.StatisticsHandler`. Can we just have a new StatisticsHandler? e.g. EndpointStatisticsHandler. So that we can get the request path from the handle method `public void handle(String path, Request baseRequest, HttpServletRequest request, HttpServletResponse response)` Thanks, Penghui On Tue, Nov 22, 2022 at 5:20 PM Jiuming Tao <jm...@streamnative.io.invalid> wrote: > Hi Haiting, > > I'm sorry I didn't explain FAILED, the FAILED means the HTTP response code > >= 400, and I’ll update the PIP later. > > Thanks, > Tao Jiuming > > > 2022年11月22日 下午5:15，Haiting Jiang <jianghait...@gmail.com> 写道： > > > > Hi Jiuming, > > > > Overall, this PIP makes sense to me. > > About the metric "pulsar_broker_rest_endpoint_failed", please provide > > a more clear definition of "fail". Are redirects like 403 included? > > > > Thanks, > > Haiting > > > > On Tue, Nov 22, 2022 at 3:17 AM Jiuming Tao > > <jm...@streamnative.io.invalid> wrote: > >> > >> Hi pulsar community, > >> > >> I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest > Endpoints > >> > >> The PIP link: https://github.com/apache/pulsar/issues/18560 < > https://github.com/apache/pulsar/issues/18560> > >> > >> Thanks, > >> Tao Jiuming > >
