Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

2023-07-16 Thread Baodi Shi
Hi, Penghui. Could you please help add a section to explain the compatibility guarantee? > Others look good to me. Added it, PTAL. Thanks, Baodi Shi On Jul 14, 2023 at 18:27:34, PengHui Li wrote: > Could you please help add a section to explain the compatibility guarantee? > Others look go

Re: [DISCUSS] Make the API compatibility guarantee clear

2023-07-16 Thread PengHui Li
Hi Yunze, Thanks for raising the discussion. IMO, The major issue is we don't have a clear API definition for the pulsar-broker module like pulsar-client-api and pulsar-client-admin-api modules. We have a clear Interface Taxonomy[0] for pulsar-client-api and pulsar-client-admin-api modules. I don

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

2023-07-16 Thread PengHui Li
Thanks, It looks good to me. Regards, Penghui On Sun, Jul 16, 2023 at 8:18 PM Baodi Shi wrote: > Hi, Penghui. > > Could you please help add a section to explain the compatibility guarantee? > > Others look good to me. > > > Added it, PTAL. > > > Thanks, > Baodi Shi > > > On Jul 14, 2023 at 18:

Re: [VOTE] Pulsar Release 2.11.2 Candidate-1

2023-07-16 Thread Yunze Xu
+1 (binding) - Built from source (Maven 3.9.3 and JDK 17.0.7) - Run standalone and verify basic e2e tests via pulsar-shell - Run standalone with KoP 2.11.1.3 and verify basic e2e cases via Kafka clients 3.4.0 Thanks, Yunze On Sun, Jul 16, 2023 at 10:55 AM wrote: > > +1 (binding) > > • Built fro

[DISCUSS] Add metrics related interfaces for BrokerInterceptor

2023-07-16 Thread Jie crossover
Hi pulsar community, I have created an issue to discuss the observability of BrokerInterceptor. The issue link: https://github.com/apache/pulsar/issues/20772 Thanks. -- Best Regards! crossoverJie