Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 2

2023-02-28 Thread Nozomi Kurihara
+1 (binding) * checked license headers * verified checksum and signature * install from npm and run producer/consumer Thanks, Nozomi 2023年2月26日(日) 12:23 Baodi Shi : > Hi everyone, > > This is the first release candidate for Apache Pulsar Node.js client, > version 1.8.1. > > It fixes the followi

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-28 Thread Zike Yang
Hi, Yunze It raises an exception when I run the consumer example. Here are my environments: * macos 12.06 x86_64 * python 3.7 Here are my reproduce steps: * Start the pulsar standalone * Start the consumer example * Start the producer example * The consumer can receive messages successfully. * S

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-28 Thread Yunze Xu
Okay, I will check it soon. Thanks, Yunze On Tue, Feb 28, 2023 at 5:17 PM Zike Yang wrote: > > Hi, Yunze > > It raises an exception when I run the consumer example. > > Here are my environments: > * macos 12.06 x86_64 > * python 3.7 > > Here are my reproduce steps: > * Start the pulsar standalon

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread ZhangJian He
ping @PengHuiLi @Enrico Olivelli Thanks ZhangJian He On Mon, 27 Feb 2023 at 14:02, ZhangJian He wrote: > > Another idea is whether it is possible to generate clients for various > languages based on the current pulsar rest swagger files > Yes. But I don't think this is a suitable choice for t

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-28 Thread ZhangJian He
ping @Zixuan Liu @Enrico Olivelli So, I am not sure if we can update to 3.x. Maybe we will need provider two versions of **pulsar-admin-client**? Thanks ZhangJian He On Mon, 27 Feb 2023 at 16:37, ZhangJian He wrote: > Sorry, what I want to talk is `pulsar-admin-client`, it uses jersey > clien

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread Zike Yang
> If the author haven't provided the context, any committer who want to add the release/* label should left a comment about why the PR should be cherry-pick. Totally agree. The committer needs to add at least one comment for the reason if he wants to add the release labels. I think we could add

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread Yubiao Feng
Append asuggestion: - After a PR revert, we need to remove the label named "release-xxx", which can alleviate the release manager's work Thanks Yubiao Feng On Mon, Feb 27, 2023 at 11:27 PM Enrico Olivelli wrote: > Hello Committers, > I believe that we should stop cherry-picking breaking changes

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread Enrico Olivelli
Il giorno mar 28 feb 2023 alle ore 11:19 Yubiao Feng ha scritto: > > Append asuggestion: > - After a PR revert, we need to remove the label named "release-xxx", which > can alleviate the release manager's work I think that it is up to the committer who merges the patch to cherry-pick immediately

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread PengHui Li
> By the way the main point in this email thread is that we should totally stop to do cherry-picks of stuff that it is not strictly needed Yes, the main issue we need to resolve is how we can define if the stuff strictly needed to cherry-pick. Do you think the author to provide the cherry-pick in

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread Enrico Olivelli
Il giorno mar 28 feb 2023 alle ore 12:11 PengHui Li ha scritto: > > > By the way the main point in this email thread is that we should > totally stop to do cherry-picks of stuff that it is > not strictly needed > > Yes, the main issue we need to resolve is how we can define if > the stuff strictl

[GitHub] [pulsar-adapters] cbornet opened a new pull request, #40: Update to Pulsar 2.11.0

2023-02-28 Thread via GitHub
cbornet opened a new pull request, #40: URL: https://github.com/apache/pulsar-adapters/pull/40 ### Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - If a feature

[GitHub] [pulsar-adapters] eolivelli commented on pull request #40: Update to Pulsar 2.11.0

2023-02-28 Thread via GitHub
eolivelli commented on PR #40: URL: https://github.com/apache/pulsar-adapters/pull/40#issuecomment-1448087003 LGTM as far as we fix the build issues :-) ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project pu

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread Enrico Olivelli
Il giorno mar 28 feb 2023 alle ore 10:40 ZhangJian He ha scritto: > > ping @PengHuiLi @Enrico Olivelli > > Thanks > ZhangJian He > > > On Mon, 27 Feb 2023 at 14:02, ZhangJian He wrote: >> >> > Another idea is whether it is possible to generate clients for various >> languages based on the current

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Enrico Olivelli
Baodi, Il giorno mar 28 feb 2023 alle ore 05:58 Baodi Shi ha scritto: > > Hi, > > In v2.11.0, the system topic enables by default [1]. This causes the > `GET_TOPICS_OF_NAMESPACE ` command to redundantly return the system topic. > > This causes some incompatibility issues: If consumers use pattern

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Yunze Xu
I agree with Enrico that we should revert this change in 2.11. BTW, I see https://github.com/apache/pulsar-client-go/pull/969 tried to upgrade the Pulsar version to 2.11 for Go client. I think we'd better skip this version. There is no need to upgrade the server version unless we have to add a new

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Baodi Shi
Yes, we can wait for the v2.11.1 release. Thanks, Baodi Shi 在 2023年2月28日 22:25:39 上,Yunze Xu 写道: > I agree with Enrico that we should revert this change in 2.11. BTW, I > see https://github.com/apache/pulsar-client-go/pull/969 tried to > upgrade the Pulsar version to 2.11 for Go client. I thi

[GitHub] [pulsar-adapters] cbornet commented on pull request #40: Update to Pulsar 2.11.0

2023-02-28 Thread via GitHub
cbornet commented on PR #40: URL: https://github.com/apache/pulsar-adapters/pull/40#issuecomment-1448310450 That's weird. It compiles fine on my machine... The Spark version used is very old and there could be an incompatibility with JDK17 -- This is an automated message from the A

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Enrico Olivelli
Il giorno mar 28 feb 2023 alle ore 15:37 Baodi Shi ha scritto: > > Yes, we can wait for the v2.11.1 release. > > > Thanks, > Baodi Shi > > > 在 2023年2月28日 22:25:39 上,Yunze Xu 写道: > > > I agree with Enrico that we should revert this change in 2.11. I am not sure that we should "revert" it. Baodi's

Re: [DISCUSS] The GET_TOPICS_OF_NAMESPACE command should filter out system topics

2023-02-28 Thread Baodi Shi
Have another problem: If the transaction is enabled, the transaction-related system topic will return by the client(__transaction_buffer_snapshot, __transaction_buffer_snapshot_segments, __transaction_buffer_snapshot_indexes). I see this PR[1] filters some transaction-related topics, but these ar

[GitHub] [pulsar-adapters] cbornet commented on pull request #40: Update to Pulsar 2.11.0

2023-02-28 Thread via GitHub
cbornet commented on PR #40: URL: https://github.com/apache/pulsar-adapters/pull/40#issuecomment-1448551957 It seems that if we update Scala, it works for Spark but not for the kafka 0.8 client wrapper. The Kafka 0.8 client wrapper is very old, depends on a very old scala version (2.9),

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-28 Thread Tao Jiuming
bump On 2023/02/13 06:56:09 Jiuming Tao wrote: > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We create a Consumer with a Dura

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-28 Thread Jiuming Tao
Bump > 2023年2月13日 14:56,Jiuming Tao > 写道: > > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We

Re: [DISCUSS] PIP-249: Pulsar website redesign

2023-02-28 Thread Asaf Mesika
So far we have 4 people giving feedback: Yu, Dave, Enrico and Kyril. Anybody else wishes to express their feedback about the content of the PIP? On Mon, Feb 27, 2023 at 3:08 PM Enrico Olivelli wrote: > I am supportive of this idea about the website. > I won't enter the details, but I have read

Re: [DISCUSS] PIP-249: Pulsar website redesign

2023-02-28 Thread tison
Hi Asaf, Here are my two coins: 1. Big +1 on the proposed change to a neutral background. The blue background makes color coordination quite difficult. 2. Since we already stick the top menu on scrolling, perhaps we don't have to change the footer to duplicate nav items. At least the proposed loo

[Discussion] Allowing configure if function consumer should skip to latest

2023-02-28 Thread Neng Lu
Hello Community, In this [PR](https://github.com/apache/pulsar/pull/17214), we changed the function protobuf by adding one more field `bool skipToLatest = 14;`. The change itself is minimum and self-contained for function internal usage. Given the new community guideline that protobuf change sho

Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Neng Lu
+1 for the change. On 2023/02/28 01:06:51 Pengcheng Jiang wrote: > Hello, community: > > ### Motivation > > Currently, pulsar functions are using `LZ4` as the compression type, and > users cannot change it, yet some users may want to custom this behavior. > > ### Modifications > > Add a `Compr

Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Rui Fu
+1, very useful, just one question: why not set the `LZ4` as the “zero” value instead? Like for the enum with following orders: `LZ4`, `NONE`, `ZLIB`, `ZSTD` and `SNAPPY`? So it will remain the backward compatibility. Best, Rui Fu On Mar 1, 2023 at 10:18 +0800, Neng Lu , wrote: > +1 for the cha

Re: [DISCUSS] Support processingGuarantees "EFFECTIVELY_ONCE" in python function

2023-02-28 Thread Rui Fu
+1 Best, Rui Fu On Feb 28, 2023 at 05:35 +0800, laminar , wrote: > Hi all, > > I would like to discuss supporting the processingGuarantess > `EFFECTIVELY_ONCE` in python function runtime. > > In this PR's(https://github.com/apache/pulsar/pull/18929) discussion, we > conclude that to achieve the

Re: [DISCUSS] ClientVersion conflict across multiple language client

2023-02-28 Thread Zike Yang
Hi, Michael, > I don't think we need to make it configurable because the library owner, not the user, has full control when creating the Connect command. The Nodejs, Python, and C client are all based on the C++ client. Same for the Scala client which is based on the Java client. They have no con

Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Pengcheng Jiang
Use `LZ4` as zero value seems better, I will update Rui Fu 于2023年3月1日周三 11:12写道: > +1, very useful, just one question: why not set the `LZ4` as the “zero” > value instead? Like for the enum with following orders: `LZ4`, `NONE`, > `ZLIB`, `ZSTD` and `SNAPPY`? So it will remain the backward compat

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-28 Thread Zixuan Liu
IMO, I think we can upgrade to jersey 3.x from jersey 2.x on the `pulsar-admin-client`. Thanks, Zixuan ZhangJian He 于2023年2月28日周二 17:44写道: > ping @Zixuan Liu @Enrico Olivelli > So, I am not sure if we can update to 3.x. Maybe we will need provider two > versions of **pulsar-admin-client**? > >

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread ZhangJian He
ping @PengHuiLi. Please let me know your thoughts on this matter. Thanks ZhangJian He On Tue, 28 Feb 2023 at 20:24, Enrico Olivelli wrote: > Il giorno mar 28 feb 2023 alle ore 10:40 ZhangJian He > ha scritto: > > > > ping @PengHuiLi @Enrico Olivelli > > > > Thanks > > ZhangJian He > > > > > >

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-28 Thread ZhangJian He
Why? How could springboot 2.x users accept this update? What do you think about this? Thanks ZhangJian He On Wed, 1 Mar 2023 at 12:11, Zixuan Liu wrote: > IMO, I think we can upgrade to jersey 3.x from jersey 2.x on the > `pulsar-admin-client`. > > Thanks, > Zixuan > > ZhangJian He 于2023年2月28

[DISCUSS] Enables pulsar to configure the `MaxRequestHeaderSize` of the internal web service

2023-02-28 Thread Yubiao Feng
Hi community The Client API can create topic names of infinite length. But after these topics were created, we can not manage them by Admin API because the web service (based by Jetty) has a request-line length limit. I propose adding a pulsar configuration `httpMaxRequestHeaderSize` to set this

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-28 Thread Yunze Xu
Hi Zike, I've reproduced this issue successfully with: - Python 3.8 on Ubuntu 20.04 - Python 3.10 on macOS 12 It seems to be a serious bug and I'm going to figure out the reason ASAP. Thanks, Yunze On Tue, Feb 28, 2023 at 5:17 PM Zike Yang wrote: > > Hi, Yunze > > It raises an exception when I