Il giorno mar 28 feb 2023 alle ore 15:37 Baodi Shi <ba...@apache.org> ha scritto: > > Yes, we can wait for the v2.11.1 release. > > > Thanks, > Baodi Shi > > > 在 2023年2月28日 22:25:39 上，Yunze Xu <y...@streamnative.io.invalid> 写道： > > > I agree with Enrico that we should revert this change in 2.11.
I am not sure that we should "revert" it. Baodi's approach works for me (to filter those topics in GET_TOPICS_OF_NAMESPACE) it is very important that old clients behave the same both with old Pulsar servers and with Pulsar 2.11 Enrico BTW, I > > see https://github.com/apache/pulsar-client-go/pull/969 tried to > > upgrade the Pulsar version to 2.11 for Go client. I think we'd better > > skip this version. There is no need to upgrade the server version > > unless we have to add a new feature that depends on the new version of > > Pulsar. > > > > Thanks, > > Yunze > > > > On Tue, Feb 28, 2023 at 9:38 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > Baodi, > > > > > > Il giorno mar 28 feb 2023 alle ore 05:58 Baodi Shi <ba...@apache.org> > > > > ha scritto: > > > > > > > > > > Hi, > > > > > > > > > > In v2.11.0, the system topic enables by default [1]. This causes the > > > > > `GET_TOPICS_OF_NAMESPACE ` command to redundantly return the system > > topic. > > > > > > > > > > This causes some incompatibility issues: If consumers use pattern > > subscribe > > > > > and the pattern is `/tenant/namespace/.*`, it will subscribe > > > > > `__change_events` topic. > > > > > > > > > > I suggest that GET_TOPICS_OF_NAMESPACE should filter out system topics(or > > > > > add include-system-topic param, like the HTTP interface[2]) to maintain > > > > > consistent behavior with versions before 2.11.0 > > > > > > I agree that the behaviour must be consistent with previous versions. > > > > > > This is a fix that we should do on 2.11.1, otherwise users upgrading > > > > from 2.10 will have a > > > > bad surprise. > > > > > > Enrico > > > > > > > > > > > > > > > > > Refer: > > > > > - [1] https://github.com/apache/pulsar/pull/15619 > > > > > - [2] https://github.com/apache/pulsar/pull/15410 > > > > > > > > > > > > > > > Thanks, > > > > > Baodi Shi > > > >
