Re: [DISCUSS] PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-16 Thread Yunze Xu
+1 to me now. Thanks, Yunze On Sat, Jan 14, 2023 at 1:29 AM Andrey Yegorov wrote: > > My bad, I pasted the interface code from a branch with experiment to cancel > events. This is no longer needed. > EventProcessingResult result is irrelevant, I updated the PIP. > > It is not in the PR. > > On F

Re: [DISCUSS] Registering Jackson Java 8 support modules by default for all Pulsar components, including client

2023-01-16 Thread Lari Hotari
I created PIP-243, https://github.com/apache/pulsar/issues/19243 . Since this is already discussed in this thread, I'll open it directly for voting. -Lari On 2023/01/09 11:05:35 Lari Hotari wrote: > Hi all, > > Jackson has a separate Java 8 support modules for adding support for proper > seria

[VOTE] PIP-243: Register Jackson Java 8 support modules by default

2023-01-16 Thread Lari Hotari
Hello community, I'm starting the VOTE for PIP-243: Register Jackson Java 8 support modules by default. Motivation: Jackson has a separate Java 8 support modules for adding support for proper serialization and deserialization of new classes that were added in Java 8 (Java 8 was released in 20

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-16 Thread r...@apache.org
I agree with @Enrico @Bo, if we encounter a subscribe stuck situation, we must continue to spend more time to locate and fix this problem, which is what we have been doing. But let's think about this problem from another angle. At this time, a user in the production environment encounters a consum

Re: [VOTE] PIP-243: Register Jackson Java 8 support modules by default

2023-01-16 Thread Nicolò Boschi
+1 Nicolò Boschi Il giorno lun 16 gen 2023 alle ore 11:17 Lari Hotari ha scritto: > Hello community, > > I'm starting the VOTE for PIP-243: Register Jackson Java 8 support modules > by default. > > Motivation: > Jackson has a separate Java 8 support modules for adding support for > proper seri

Re: [VOTE] PIP-243: Register Jackson Java 8 support modules by default

2023-01-16 Thread r...@apache.org
+1 Xiaolong Ran

Re: [VOTE] PIP-243: Register Jackson Java 8 support modules by default

2023-01-16 Thread Christophe Bornet
+1 Le lun. 16 janv. 2023 à 11:16, Lari Hotari a écrit : > Hello community, > > I'm starting the VOTE for PIP-243: Register Jackson Java 8 support modules > by default. > > Motivation: > Jackson has a separate Java 8 support modules for adding support for > proper serialization and deserializatio

[VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Alexander Preuss
Hi everyone, I'm starting the VOTE for PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext: https://github.com/apache/pulsar/issues/19123 Discussion thread: https://lists.apache.org/thread/b8r6b4p87qzfgfwmqfql7mqx8kmgorxg I'd like to go ahead with implementing option B presente

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-16 Thread SiNan Liu
I understand the proto version, and I updated the PIP issue, please check it. Thanks, Sinan PengHui Li 于2023年1月16日周一 12:08写道: > > Is there any problem with using a positive value for it? I think there > is no compatibility issue because the enum value is never used on the > broker side. Making

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-16 Thread Enrico Olivelli
I think that in "Alternatives" you should mention the approach of adding a boolean (optional) field to the subscribe request Enrico Il giorno lun 16 gen 2023 alle ore 15:32 SiNan Liu ha scritto: > > I understand the proto version, and I updated the PIP issue, please check > it. > > Thanks, > Sin

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Enrico Olivelli
The proposal makes sense to me. I suggest to put option B into the API changes and move option A to "Alternatives" Enrico Il giorno mar 3 gen 2023 alle ore 15:32 Alexander Preuss ha scritto: > > Hi all, > > I opened a PIP to discuss making PulsarAdmin accessible in Pulsar IO > connectors throug

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Enrico Olivelli
Alexander, I am sorry but it looks too premature to start the VOTE thread, as the DISCUSSION thread has not been participated. Let's wait that other folks give their opinions (personally I missed the initial email and I have found it now) Thanks for your efforts on this initiative Enrico Il gior

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-16 Thread SiNan Liu
Ok, it's done. Thanks, Sinan Enrico Olivelli 于2023年1月16日周一 22:38写道: > I think that in "Alternatives" you should mention the approach of > adding a boolean (optional) field to the subscribe request > > Enrico > > Il giorno lun 16 gen 2023 alle ore 15:32 SiNan Liu > ha scritto: > > > > I underst

[DISCUSS] Make the default value of param "--get-subscription-backlog-size" of admin API "topics stats" true

2023-01-16 Thread Yubiao Feng
Hi community I am starting a DISCUSS for making the default value of the parameter "--get-subscription-backlog-size" of admin API "topics stats" true. In the PR https://github.com/apache/pulsar/pull/9302, the property backlog size of each subscription returned in the response of the API topics st

Re: [DISCUSS] Make the default value of param "--get-subscription-backlog-size" of admin API "topics stats" true

2023-01-16 Thread PengHui Li
+1 Penghui > On Jan 16, 2023, at 23:36, Yubiao Feng > wrote: > > Hi community > > I am starting a DISCUSS for making the default value of the parameter > "--get-subscription-backlog-size" of admin API "topics stats" true. > > In the PR https://github.com/apache/pulsar/pull/9302, the property

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Bonan Hou
+1 for option b. Bonan Hou On Tue, Jan 3, 2023 at 10:32 PM Alexander Preuss wrote: > Hi all, > > I opened a PIP to discuss making PulsarAdmin accessible in Pulsar IO > connectors through SinkContext and SourceContext: > https://github.com/apache/pulsar/issues/19123 > > Looking forward to hearin

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Bonan Hou
+1 Bonan Hou On Mon, Jan 16, 2023 at 9:56 PM Alexander Preuss wrote: > Hi everyone, > > I'm starting the VOTE for PIP-237: Make PulsarAdmin accessible in > SinkContext and SourceContext: > https://github.com/apache/pulsar/issues/19123 > > Discussion thread: > https://lists.apache.org/thread/b8r

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-16 Thread Nitin Goyal
Hello all, I have a few questions. 1. When a message is NACKed does it still send the commands to the broker? 2. Do we have any plan to replace the ReconsumeLater function with NACK Backoff interface in future? On Tue, Jan 10, 2023 at 7:17 PM Nitin Goyal wrote: > Hello Team, > > Thanks for po

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-16 Thread Yunze Xu
> Maybe 100 or something. I see the updated PR adopts this suggestion to set the enum value with 100. But I'm still wondering why not just use the next enum value (21)? What makes AUTO_CONSUME schema different from other schema types like ProtobufNativeSchema (20). Thanks, Yunze On Mon, Jan 16,

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-16 Thread SiNan Liu
Haha, it should have been set to 21. I studied the proto version carefully, but I didn't think about the enum value. I'll update this value later. Thanks, Sinan Yunze Xu 于 2023年1月17日周二 下午12:11写道: > > Maybe 100 or something. > > I see the updated PR adopts this suggestion to set the enum value w

Re: [DISCUSS] Registering Jackson Java 8 support modules by default for all Pulsar components, including client

2023-01-16 Thread Asaf Mesika
Can the scenarios of breaking changes for users be described in the PIP if they exist? If this is a breaking change, it might be a good thing to point it out in the PIP and in the release notes ("If you did this, then perhaps you want to do that"). Context question since I'm not familiar with func

Re: [DISCUSS] Make the default value of param "--get-subscription-backlog-size" of admin API "topics stats" true

2023-01-16 Thread Asaf Mesika
Small question regarding this: The code for calculation is: long estimateBacklogFromPosition(PositionImpl pos) { synchronized (this) { long sizeBeforePosLedger = ledgers.headMap(pos.getLedgerId()).values() .stream().mapToLong(LedgerInfo::getSize).sum(); LedgerI

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-16 Thread Asaf Mesika
>From my knowledge, when a client does negative ack, after a certain amount of time, it sends the following command to the broker containing the negatively acked messages ids: message CommandRedeliverUnacknowledgedMessages { required uint64 consumer_id = 1; repeated MessageIdData message_i

Re: [DISCUSS] PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-16 Thread Enrico Olivelli
I support this PIP. This will allow Protocol Handlers to have better knowledge of what's happening on the broker. I hope that someday we will be able to refactor Broker internals using this feature and decouple the components. Enrico Il giorno lun 16 gen 2023 alle ore 10:27 Yunze Xu ha scritto:

Re: [DISCUSS] Should we bump up Node.js Client for C++ Client's upgrade

2023-01-16 Thread Yuto Furuta
Thank you for your comments. I proposed the versioning rule of Node.js Client. Please review it if you have time. https://github.com/apache/pulsar-client-node/pull/287 Thanks, Yuto Yuto Furuta Yahoo Japan Corp. E-mail: yfur...@yahoo-corp.jp 差出人: Yunze Xu 送信日時: