Re: [DISCUSS][doc][improve] Update Pulsar site landing page content #349

2023-01-15 Thread Asaf Mesika
I'm pasting the context described in the PR also here: Pulsar’s landing page has a key role in getting new people “onboard” Apache Pulsar - effectively getting people from “Pulsar? Never heard about it, what is it good for?” to “Wow, that’s an amazi

[DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Ruguo Yu
Hi Community, Currently, we can use PulsarClient to create `Producer`, `Consumer`, `Reader` and `TableView`, releated method as below: ``` ProducerBuilder newProducer(); ProducerBuilder newProducer(Schema schema); ConsumerBuilder newConsumer(); ConsumerBuilder newConsumer(Schema schema);

Re: [DISCUSS] PIP-235: Add metric for subscription back size

2023-01-15 Thread Jiuming Tao
Hi Xiao, Seems `backlogSize` already existed in the `SubscriptionStatsImpl`, but didn’t expose in Prometheus, We just need to expose it in Prometheus. It should exposed in Prometheus when the configuration named `exposeTopicLevelMetricsInPrometheus` and `exposeSubscriptionBacklogSizeInPrometh

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-15 Thread Yubiao Feng
Hi @Enrico @Bo > If there is a problem we should spend time on investigating the problem and not in adding this kind of tools. You are right. When a user encounters a problem, it often takes a while to solve the root cause. It is important to provide a tool to recover services quickly, and cmd 'u

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-15 Thread Yubiao Feng
Hi Qiang > 1. How do you handle the race condition when you are trying to unload the subscription, and the new consumer wants to subscribe to this subscription at the same time? I'm unsure if it has the race condition. I just want to remind you about that.:) These methods `addConsumer`, `removeCo

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-15 Thread PengHui Li
> This design also has serious compatibility problems between old and new pulsar clients and new and old brokers. Could you please explain more details of the compatibility issue if we leverage the protocol version? > We should not use a negative enum number in PulsarApi.proto. It's unnatural. If

Re: [DISCUSS] KeyShared routing additions/configuration

2023-01-15 Thread PengHui Li
Hi Tim, > The proposal is two-fold: first, we would like to implement a new KeyShared routing mechanism which tracks outstanding messages and their consumers, routing messages with outstanding keys to the current consumer handling that key, and any messages with new keys to any arbitrary consumer

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread PengHui Li
+1 And It might be a typo when adding the table view APIs >From the example: https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java#L232-L238 And from the proposal, the method name is newTableV

RE: Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Ruguo Yu
Sorry,I forgot to paste the corresponding PR: https://github.com/apache/pulsar/pull/19048 I have fixed the typo in above PR. On 2023/01/16 02:10:07 PengHui Li wrote: > +1 > > And It might be a typo when adding the table view APIs > From the example: > > https://github.com/apache/pulsa

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-15 Thread Yunze Xu
Is there any problem with using a positive value for it? I think there is no compatibility issue because the enum value is never used on the broker side. Making it positive makes AUTO_CONSUME different with other implicit schema types like BYTES, AUTO and AUTO_PUBLISH. Thanks, Yunze On Mon, Jan 1

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-15 Thread PengHui Li
> Is there any problem with using a positive value for it? I think there is no compatibility issue because the enum value is never used on the broker side. Making it positive makes AUTO_CONSUME different with other implicit schema types like BYTES, AUTO and AUTO_PUBLISH. That sounds good to me to

Re: Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Enrico Olivelli
+1 Enrico Il Lun 16 Gen 2023, 03:38 Ruguo Yu ha scritto: > Sorry,I forgot to paste the corresponding PR: > https://github.com/apache/pulsar/pull/19048 > > I have fixed the typo in above PR. > > > > On 2023/01/16 02:10:07 PengHui Li wrote: > > > +1 > > > > > > And It might be a typo when addin

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Enrico Olivelli
+1 Enrico Il Lun 16 Gen 2023, 03:11 PengHui Li ha scritto: > +1 > > And It might be a typo when adding the table view APIs > From the example: > > > https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Pulsar