+1
Enrico Il Lun 16 Gen 2023, 03:38 Ruguo Yu <jiang7chengz...@163.com> ha scritto: > Sorry,I forgot to paste the corresponding PR: > https://github.com/apache/pulsar/pull/19048 > > I have fixed the typo in above PR. > > > > On 2023/01/16 02:10:07 PengHui Li wrote: > > > +1 > > > > > > And It might be a typo when adding the table view APIs > > > From the example: > > > > > > > https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java#L232-L238 > > > > > > And from the proposal, the method name is newTableView() > > > > > > https://github.com/apache/pulsar/issues/12356 > > > > > > Thanks, > > > Penghui > > > > > > On Sun, Jan 15, 2023 at 6:31 PM Ruguo Yu <jiang7chengz...@163.com> > wrote: > > > > > > > Hi Community, > > > > > > > > Currently, we can use PulsarClient to create `Producer`, `Consumer`, > > > > `Reader` and `TableView`, releated method as below: > > > > > > > > ``` > > > > > > > > ProducerBuilder<byte[]> newProducer(); > > > > > > > > <T> ProducerBuilder<T> newProducer(Schema<T> schema); > > > > > > > > ConsumerBuilder<byte[]> newConsumer(); > > > > > > > > <T> ConsumerBuilder<T> newConsumer(Schema<T> schema); > > > > > > > > ReaderBuilder<byte[]> newReader(); > > > > > > > > <T> ReaderBuilder<T> newReader(Schema<T> schema); > > > > > > > > <T> TableViewBuilder<T> newTableViewBuilder(Schema<T> schema); > > > > > > > > ``` > > > > > > > > However, it is obvious that the method of creating `TableView` is not > > > > consistent with other methods, and no method with default scheme is > > > > provided. > > > > > > > > > > > > > > > > ### Motivation > > > > > > > > Add unified `newTableView(Schema)` method and replace > > > > `newTableViewBuilder(Schema)`(attach `@Deprecated` annotation to it) in > > > > PulsarClient, which could consistent with `newProducer(Schema)`, > > > > `newConsumer(Schema)`, `newReader(Schema)`. > > > > > > > > In addition, we will provide `newTableView()` method which has default > > > > schema. > > > > > > > > > > > > > > > > ### Modifications > > > > > > > > 1. Add `newTableView(Schema)` method and replace > > > > `newTableViewBuilder(Schema)`(attach `@Deprecated` annotation to it) > in > > > > PulsarClient > > > > > > > > 2. Add `newTableView()` method and Scheme default is `Schema.BYTES` in > > > > PulsarClient > > > > > > > > > > > > > > > > Thanks > > > > > > > > Ruguo Yu > > > > > > > > > > > > > > > > >
