Re: [DISCUSS] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-22 Thread 丛搏
Hi Yunze, +1(non-binding) Thank you very much for your patience. I have no other problem now. Great PIP! Thanks, Bo Yunze Xu 于2022年12月22日周四 15:29写道: > > Hi Penghui and Bo, > > I realized this problem as well. No new APIs should be added. I added > the new API mainly to express that the semant

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 1

2022-12-22 Thread Zike Yang
There is an issue when publishing the pulsar node client 1.8.0-rc1 to npm. Close this vote, and I will start releasing candidate 2 soon. Thanks, Zike Yang On Wed, Dec 21, 2022 at 5:28 PM Zike Yang wrote: > > Hi everyone, > > This is the first release candidate for the Apache Pulsar Node.js > cli

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 1

2022-12-22 Thread Nozomi Kurihara
Hi Zike, Thank you for driving this release. I have found 2 issues, vulnerable dependency and missing license headers, so could you include them to 1.8.0-rc2? * https://github.com/apache/pulsar-client-node/pull/261 * https://github.com/apache/pulsar-client-node/pull/262 Best Regards, Nozomi 202

[VOTE] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-22 Thread Yunze Xu
Hi all, I'm starting the VOTE for PIP-229: Add a common interface to get fields of MessageIdData: https://github.com/apache/pulsar/issues/18950 Discussion thread: https://lists.apache.org/thread/25rzflmkfmvxhf3my0ombnbpv7bvgy32 The vote will be open for at least 3 days. Thanks, Yunze

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-22 Thread Yubiao Feng
+1 Thanks Yubiao On Thu, Dec 22, 2022 at 9:04 AM PengHui Li wrote: > > I notice that if changing the default value of conf `ioThreads` of pulsar > > client, it does not just affect the num of io threads, and it also > affects > > these thread pools: > > - internal executor of the client > > - s

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-22 Thread Lari Hotari
> My concern is whether this change will affect some users who are creating > many clients. This is a good point. There's an internal API to share the thread pools across clients. There's a code example in the Pulsar code base, https://github.com/apache/pulsar/blob/f029757ecb9653a97710f2bac563

[DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread Michael Marshall
Hello Pulsar Community, We've had GitHub discussions enabled for a while now. I think they're a helpful way for users to ask questions. I also think they are creating too many notifications to the dev@ list, which can make it hard to keep up with PIPs, VOTEs, and other dev discussions. I propose

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 1

2022-12-22 Thread Zike Yang
Hi, Nozomi Sure. I will add them to rc2. Thanks, Zike Yang On Thu, Dec 22, 2022 at 6:45 PM Nozomi Kurihara wrote: > > Hi Zike, > > Thank you for driving this release. > > I have found 2 issues, vulnerable dependency and missing license headers, > so could you include them to 1.8.0-rc2? > * http

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread Yunze Xu
+1 Thanks, Yunze On Fri, Dec 23, 2022 at 6:04 AM Michael Marshall wrote: > > Hello Pulsar Community, > > We've had GitHub discussions enabled for a while now. I think they're > a helpful way for users to ask questions. I also think they are > creating too many notifications to the dev@ list, whi

Re: [VOTE] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-22 Thread 丛搏
+1 (non-binding) Thanks, Bo Yunze Xu 于2022年12月22日周四 20:34写道: > > Hi all, > > I'm starting the VOTE for PIP-229: Add a common interface to get > fields of MessageIdData: https://github.com/apache/pulsar/issues/18950 > > Discussion thread: > https://lists.apache.org/thread/25rzflmkfmvxhf3my0ombnbp

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread PengHui Li
Is it better to point to user@ list? I noticed that most discussions are user-facing issues(Requirements, Questions) Thanks, Penghui On Fri, Dec 23, 2022 at 10:18 AM Yunze Xu wrote: > +1 > > Thanks, > Yunze > > On Fri, Dec 23, 2022 at 6:04 AM Michael Marshall > wrote: > > > > Hello Pulsar Comm

Re: [VOTE] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-22 Thread PengHui Li
+1(binding) Thanks, Penghui On Fri, Dec 23, 2022 at 10:31 AM 丛搏 wrote: > +1 (non-binding) > > Thanks, > Bo > > Yunze Xu 于2022年12月22日周四 20:34写道: > > > > Hi all, > > > > I'm starting the VOTE for PIP-229: Add a common interface to get > > fields of MessageIdData: https://github.com/apache/pulsar

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-12-22 Thread 丛搏
Hi, Asaf, Baodi: I'm very sorry for my late reply. Thanks for your discussion. > - receive() - get the following message > - cumulativeAck(msgId) - acknowledge all messages up to msgId. > - Maybe we can try to come up with a self-explanatory name like > ackAllUpTo(msgId). If the user w

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread Zike Yang
+1 for pointing to user list. Thanks, Zike Yang On Fri, Dec 23, 2022 at 11:00 AM PengHui Li wrote: > > Is it better to point to user@ list? > I noticed that most discussions are user-facing issues(Requirements, > Questions) > > Thanks, > Penghui > > On Fri, Dec 23, 2022 at 10:18 AM Yunze Xu > w

Re: [VOTE] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-22 Thread Yunze Xu
It needs the 3rd binding +1 yet. Could anyone else take a look? Thanks, Yunze On Wed, Dec 21, 2022 at 3:21 PM 丛搏 wrote: > > Hi Yunze, > > add `TopicMessageId ` will couple messageID and `topic name` together, > which is very unclear for non-partition-topic. > > ``` > void seek(String topicName,

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread Dave Fisher
Sent from my iPhone > On Dec 22, 2022, at 7:00 PM, PengHui Li wrote: > > Is it better to point to user@ list? > I noticed that most discussions are user-facing issues(Requirements, > Questions) I agree. In addition, we should discuss in another thread how to guide user and dev discussion

Re: [VOTE] Pulsar Client Python Release 3.0.0 Candidate 3

2022-12-22 Thread guo jiwei
+1 (binding) - Checked the signature - Install the python .whl file (pip3 install pulsar_client-3.0.0-cp38-cp38-macosx_10_15_universal2.whl) on macOS 12.6(21G115) - Start the standalone (build from the master branch) - Start consumer (python3 ./examples/consumer.py) - Start producer (python3 ./exa

Re: [VOTE] Pulsar Client Python Release 3.0.0 Candidate 3

2022-12-22 Thread Dave Fisher
I haven’t had a chance to review this RC yet, but I did notice the reorganization of the directories and wanted to compliment this change as very helpful! Also, adding a source release is responsive. Best, Dave Sent from my iPhone > On Dec 22, 2022, at 9:32 PM, guo jiwei wrote: > > +1 (bin

Re: [DISCUSS] Move GitHub discussion notifications to commits@

2022-12-22 Thread 丛搏
+1 for pointing to the user list. Thanks, Bo Dave Fisher 于2022年12月23日周五 12:48写道: > > > > Sent from my iPhone > > > On Dec 22, 2022, at 7:00 PM, PengHui Li wrote: > > > > Is it better to point to user@ list? > > I noticed that most discussions are user-facing issues(Requirements, > > Questions)