Hi, Nozomi

Sure. I will add them to rc2.

Thanks,
Zike Yang

On Thu, Dec 22, 2022 at 6:45 PM Nozomi Kurihara <nkuri...@apache.org> wrote:
>
> Hi Zike,
>
> Thank you for driving this release.
>
> I have found 2 issues, vulnerable dependency and missing license headers,
> so could you include them to 1.8.0-rc2?
> * https://github.com/apache/pulsar-client-node/pull/261
> * https://github.com/apache/pulsar-client-node/pull/262
>
> Best Regards,
> Nozomi
>
> 2022年12月22日(木) 17:30 Zike Yang <z...@apache.org>:
>
> > There is an issue when publishing the pulsar node client 1.8.0-rc1 to npm.
> > Close this vote, and I will start releasing candidate 2 soon.
> >
> > Thanks,
> > Zike Yang
> >
> > On Wed, Dec 21, 2022 at 5:28 PM Zike Yang <z...@apache.org> wrote:
> > >
> > > Hi everyone,
> > >
> > > This is the first release candidate for the Apache Pulsar Node.js
> > > client, version 1.8.0.
> > >
> > > It fixes the following issues:
> > > https://github.com/apache/pulsar-client-node/milestone/13?closed=1
> > >
> > > Please download the source files and review this release candidate:
> > > - Download the source package, verify shasum and asc
> > > - Follow the README.md to build and run the Pulsar Node.js client.
> > >
> > > I have created a repo here to help you verify it more easily:
> > > https://github.com/RobertIndie/pulsar-client-node-validation. Please
> > > read the README file for more information.
> > > The automatic release validation has been passed:
> > >
> > https://github.com/RobertIndie/pulsar-client-node-validation/actions/runs/3747965037
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Source files:
> > >
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-1/
> > >
> > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> > >
> > > SHA-512 checksum:
> > >
> > 98326718eb7de20b3ebb12a4908ae195ec56e506b8c465b14eaa2e4191a2778bda6dbdbd1e2ceb654a1fdc7bb6d908a3bd8018e9f49e40215d3534a568105aff
> > >  pulsar-client-node-1.8.0.tar.gz
> > >
> > > The tag to be voted upon:
> > > v1.8.0-rc.1
> > > https://github.com/apache/pulsar-client-node/releases/tag/v1.8.0-rc.1
> > >
> > > Please review and vote on the release candidate #1 for the version
> > > 1.8.0, as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > Thanks,
> > > Zike Yang
> >

Reply via email to