Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

+1 (unbinding) Thanks, Ran On 2022/11/17 09:06:50 Jiuming Tao wrote: > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18319 > > > Discuss thread: > https://lists.apache.org/t

Re: [VOTE] PIP-211: Introduce offload throttling

+1 binding Thanks, Haiting On Mon, Nov 21, 2022 at 7:03 PM Jiuming Tao wrote: > > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18004 > > > Discuss thread: > https://lists.apa

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

Hi Jiuming, Overall, this PIP makes sense to me. About the metric "pulsar_broker_rest_endpoint_failed", please provide a more clear definition of "fail". Are redirects like 403 included? Thanks, Haiting On Tue, Nov 22, 2022 at 3:17 AM Jiuming Tao wrote: > > Hi pulsar community, > > I’ve opened

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

Hi Haiting, I'm sorry I didn't explain FAILED, the FAILED means the HTTP response code >= 400, and I’ll update the PIP later. Thanks, Tao Jiuming > 2022年11月22日 下午5:15，Haiting Jiang 写道： > > Hi Jiuming, > > Overall, this PIP makes sense to me. > About the metric "pulsar_broker_rest_endpoint_fa

Re: [VOTE] PIP-211: Introduce offload throttling

+1 binding Enrico Il Mar 22 Nov 2022, 09:42 Haiting Jiang ha scritto: > +1 binding > > Thanks, > Haiting > > On Mon, Nov 21, 2022 at 7:03 PM Jiuming Tao > wrote: > > > > Dear Pulsar Community, > > > > Please review and vote on this PIP. > > > > PIP link: https://github.com/apache/pulsar/issues

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

Hi Congbo I think it is a goog idea. Thanks Yubiao Yu On Mon, Nov 21, 2022 at 9:04 PM 丛搏 wrote: > Hello, Pulsar community: > > Now client consumer `void redeliverUnacknowledgedMessages();` is an > async interface, but it doesn't have the return value. only > `writeAndFlush` the redeliver comma

Re: [VOTE] PIP-211: Introduce offload throttling

+1 binding Penghui On Tue, Nov 22, 2022 at 6:03 PM Enrico Olivelli wrote: > +1 binding > > Enrico > > Il Mar 22 Nov 2022, 09:42 Haiting Jiang ha > scritto: > > > +1 binding > > > > Thanks, > > Haiting > > > > On Mon, Nov 21, 2022 at 7:03 PM Jiuming Tao > > wrote: > > > > > > Dear Pulsar Commu

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

Hi, Jiuming Thanks for starting the proposal. We'd better add an option to enable or disable the endpoint-level metrics. And keep it as disabled as default. I noticed the existing jetty metrics are based on `org.eclipse.jetty.server.handler.StatisticsHandler`. Can we just have a new StatisticsHa

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

Hi, Bo Thanks for starting the discussion. I have no idea about the initial motivation for supporting message redelivery for Failover or Exclusive subscription. The redelivered messages will go to the same consumer under a single active consumer subscription mode. Or maybe it is only designed fo

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

Hi Penghui, > We'd better add an option to enable or disable the endpoint-level metrics. > And keep it as disabled as default. Agreed, I also considered if we need a configuration to enable/disable the feature, seems add an option is better > So that we can > get the request path from the handl

Re: [VOTE] Pulsar Release 2.11.0 Candidate 1

Hi Jiwei, Thank you for cutting this RC. When following the processes in "Validate Release Candidate", command `nc -vz4 localhost 4181` fails. which means table service is not started in standalone mode. Is this expected or a bug? > Since the metadata store is changed from ZK to etcd, I think y

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

Hi Jiuming, I am not sure why we need a new metric for failed requests. Can we just put the `httpcode` tag also in the `pulsar_broker_rest_endpoint_latency_ms`? So that user can also see the latency of failed requests (like timeout requests). And it can easily cover the case of failed metrics. Th

Re: [VOTE] Pulsar Release 2.11.0 Candidate 1

Il giorno mer 23 nov 2022 alle ore 05:43 Haiting Jiang ha scritto: > > Hi Jiwei, > > Thank you for cutting this RC. > > When following the processes in "Validate Release Candidate", > command `nc -vz4 localhost 4181` fails. which means table service is > not started in standalone mode. > Is this e