[VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
Dear Pulsar Community, Please review and vote on this PIP. PIP link: https://github.com/apache/pulsar/issues/18319 Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Enrico Olivelli
Tao, before voting on this proposal, I think that we should change the title. Now the PIP refers to tracking all the commands and not only CommandPartitionedTopicMetadata, is this correct? Enrico Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao ha scritto: > > Dear Pulsar Community, > > Plea

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
Hi Enrico, Tracking all the cmds will lead to a lot of changes, BrokerInterceptors only triggered when the cmd entering. This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find a way to track all the cmds, and I’ll create another PIP the do it. Thanks, Tao Jiuming > 2022年11月1

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Enrico Olivelli
+1 (binding) My understanding is that the PIP will add a generic mechanism to track commands ("pulsar_broker_command_execution_latency" with label "code") but we will implement it only for CommandPartitionedTopicMetadata Enrico Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao ha scritto: >

Re: [DISCUSS] PIP-210

2022-11-17 Thread houxiaoyu
Hi Prashant, I generally support this PIP. Is it possible that we also add a flag to prevent messages pick this partition for a period of time if the pendingMessage queue is full? Assume that the partition has broken, the following will happen: 1. The pendingMessage queue will be full; 2. Produ

[DIDSCUSS] Realease Pulsar 2.9.4 cherry-pick done

2022-11-17 Thread 丛搏
Hello, Pulsar community: The cherry-pick of 2.9.4 is basically completed. Contains about 300+ PRs. link: https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.9.4 If you still have a pr that must be released in pulsar-2.9.4, please reply to me or ping me on GitHub. Thanks, Bo

[DISCUSS] Remove "triage" series labels?

2022-11-17 Thread tison
Hi, When squashing issue backlog, I noticed there're a number of "legacy" tags in series "traige/week-x". It seems the initiative has been halted and those labels don't provide continuous value. Thus I suggest we remove "triage" series labels to reduce engineering debt. What do you think? Best,

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
My understanding is that the PIP will add a generic mechanism to track commands ("pulsar_broker_command_execution_latency" with label "code”) pulsar_broker_command_execution_latency with `command` label to track the command execution latency pulsar_broker_command_execution_failed with `command`

Re: [Vote] PIP-220 TransferShedder (only for PIP-192 New Broker Load Balancer)

2022-11-17 Thread Matteo Merli
+1 -- Matteo Merli On Tue, Nov 15, 2022 at 3:20 PM Heesung Sohn wrote: > > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18215 > > Thank you, > -Heesung

Re: [DISCUSS] Remove "triage" series labels?

2022-11-17 Thread Matteo Merli
+1 Good suggestion -- Matteo Merli On Thu, Nov 17, 2022 at 7:32 AM tison wrote: > > Hi, > > When squashing issue backlog, I noticed there're a number of "legacy" tags > in series "traige/week-x". > > It seems the initiative has been halted and those labels don't provide > continuous value. Thu

Re: [Vote] PIP-192 New Pulsar Broker Load Balancer

2022-11-17 Thread Heesung Sohn
Dear Pulsar Community, To track sub-PIPs and PRs, I put a project status in the PIP here. https://github.com/apache/pulsar/issues/16691#issuecomment-1318959420 Please help to review them to move this project forward. Thank you, Heesung On Mon, Oct 17, 2022 at 6:07 PM Heesung Sohn wrote: > Hi

Re: [DISCUSS] Remove "triage" series labels?

2022-11-17 Thread Enrico Olivelli
+1 Enrico Il Gio 17 Nov 2022, 18:40 Matteo Merli ha scritto: > +1 Good suggestion > > > -- > Matteo Merli > > > On Thu, Nov 17, 2022 at 7:32 AM tison wrote: > > > > Hi, > > > > When squashing issue backlog, I noticed there're a number of "legacy" > tags > > in series "traige/week-x". > > > >

Re: [DISCUSS] Remove "triage" series labels?

2022-11-17 Thread Yunze Xu
+1 Thanks, Yunze On Fri, Nov 18, 2022 at 3:12 AM Enrico Olivelli wrote: > > +1 > > Enrico > > Il Gio 17 Nov 2022, 18:40 Matteo Merli ha scritto: > > > +1 Good suggestion > > > > > > -- > > Matteo Merli > > > > > > On Thu, Nov 17, 2022 at 7:32 AM tison wrote: > > > > > > Hi, > > > > > > When s

Re: [DIDSCUSS] Realease Pulsar 2.9.4 cherry-pick done

2022-11-17 Thread Yunze Xu
https://github.com/apache/pulsar/pull/18486 should be cherry-picked to 2.9.4 because it fixes a bug introduced in https://github.com/apache/pulsar/pull/18454, which has already been cherry-picked. Thanks, Yunze On Thu, Nov 17, 2022 at 8:26 PM 丛搏 wrote: > > Hello, Pulsar community: > > The cherry

[DISCUSS] Add an option to keep compatibility for HTTP lookup of legacy clients

2022-11-17 Thread Yunze Xu
Hi all, There is a breaking change for old version clients when using HTTP lookup, see details in discussion here[1]. The affected clients I know are: - Java client 2.4.1 or earlier - C++/Python clients 2.8.0 or earlier In short, #10601 changed the behavior for querying the partition metadata of

Re: [DISCUSS] Add an option to keep compatibility for HTTP lookup of legacy clients

2022-11-17 Thread Yunze Xu
I've investigated more on this issue. The `allowAutoTopicCreationType` config introduced in https://github.com/apache/pulsar/pull/4963 also brings an incompatibility but it's not serious. I ran a standalone of Pulsar 2.5.0 (need to use JDK 8) with the following config: ``` allowAutoTopicCreationT

Re: [Vote] PIP-220 TransferShedder (only for PIP-192 New Broker Load Balancer)

2022-11-17 Thread PengHui Li
+1 Penghui On Fri, Nov 18, 2022 at 1:40 AM Matteo Merli wrote: > +1 > > > -- > Matteo Merli > > > On Tue, Nov 15, 2022 at 3:20 PM Heesung Sohn > wrote: > > > > Dear Pulsar Community, > > > > Please review and vote on this PIP. > > > > PIP link: https://github.com/apache/pulsar/issues/18215 >

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread PengHui Li
+1 Penghui On Fri, Nov 18, 2022 at 12:51 AM Jiuming Tao wrote: > My understanding is that the PIP will add a generic mechanism to track > commands ("pulsar_broker_command_execution_latency" with label > "code”) > > > pulsar_broker_command_execution_latency with `command` label to track the > c