+1 (binding) My understanding is that the PIP will add a generic mechanism to track commands ("pulsar_broker_command_execution_latency" with label "code") but we will implement it only for CommandPartitionedTopicMetadata Enrico
Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao <jm...@streamnative.io.invalid> ha scritto: > > Hi Enrico, > > Tracking all the cmds will lead to a lot of changes, BrokerInterceptors only > triggered when the cmd entering. > > This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find a way > to track all the cmds, and I’ll > create another PIP the do it. > > > Thanks, > Tao Jiuming > > > 2022年11月17日 下午5:27,Enrico Olivelli <eolive...@gmail.com> 写道: > > > > Tao, > > before voting on this proposal, I think that we should change the title. > > Now the PIP refers to tracking all the commands and not only > > CommandPartitionedTopicMetadata, is this correct? > > > > Enrico > > > > Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao > > <jm...@streamnative.io.invalid> ha scritto: > >> > >> Dear Pulsar Community, > >> > >> Please review and vote on this PIP. > >> > >> PIP link: https://github.com/apache/pulsar/issues/18319 > >> <https://github.com/apache/pulsar/issues/18319> > >> > >> Discuss thread: > >> https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6 > >> <https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6> > >> > >> Thanks, > >> Tao Jiuming >