massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825638693
##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer,
pulsar_message_t *cMessage, v
list
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825664237
##
File path: src/Consumer.cc
##
@@ -225,14 +214,17 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
~ConsumerReceiveWorker() {}
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825667640
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825670362
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825672970
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825675677
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825615679
##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer,
pulsar_message_t *cMessage, v
list
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825685738
##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer,
pulsar_message_t *cMessage, v
list
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825664237
##
File path: src/Consumer.cc
##
@@ -225,14 +214,17 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
~ConsumerReceiveWorker() {}
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825667640
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825672970
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825675677
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825699223
##
File path: tests/end_to_end.test.js
##
@@ -106,7 +106,7 @@ const Pulsar = require('../index.js');
consumer.acknowledge(msg2);
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825699449
##
File path: tests/end_to_end.test.js
##
@@ -302,7 +302,7 @@ const Pulsar = require('../index.js');
}
await expect(consumer.rec
massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825670362
##
File path: src/Consumer.cc
##
@@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
private:
Napi::Promise:
Hi Pulsar community,
Currently, the reader support sets the start message id and enables the
inclusive.
I have a case that always read the latest message, set the MessageId.latest
as start message id with enabling the inclusive, the code so like:
```
@Test
public void testReaderGetsLatestInclusiv
Hi Zixuan,
We are not able to add `hasMessageAvailable()` check before `readNext()`
method.
For some cases, they care about if they need to do something if no messages
are available,
but some cases are not, just continues to read the messages from the topic,
so they don't need
to check if there ar
Thanks for reviewing and voting. Can the proposal be accepted now?
On Mon, 14 Mar 2022 at 06:47, Hang Chen wrote:
> +1
>
> Thanks,
> Hang
>
> Aparajita Singh 于2022年3月11日周五 10:41写道：
> >
> > *bump*
> >
> >
> > On Wed, 9 Mar 2022, 18:30 PengHui Li, wrote:
> >
> > > +1
> > >
> > > Penghui
> > >
>
Hi, Zixuan,
Very glad you can notice this problem. I am preparing to submit a PIP to
resolve this issue.
This pip is to add a new field to the CommandSubscribe to let the broker know
how to set the cursor position.
Feel free to give me more good advice and let me know what you think.
Best,
Ma
HuynhKevin opened a new pull request #244:
URL: https://github.com/apache/pulsar-helm-chart/pull/244
All components have the imagePullSecrets to avoid quota limit to init
correctly the pods except zookeeper
--
This is an automated message from the Apache Git Service.
To respond to th
There is problem when initialized cluster by using initialize-cluster-metadata
with multiple ZK servers configed.
eg:
bin/pulsar initialize-cluster-metadata --cluster test --metadata-store
zk1:2181,zk2:2181/test --configuration-metadata-store zk1:2181,zk2:2181/test
--
It's bookkeeper's problem. fix pr
:https://github.com/apache/bookkeeper/pull/3109/files
-- --
??:
"dev"
Hi Aparajita,
Thanks for you contribution. This proposal has 3 (+1) bindings and
0 (-1). You can close this vote now and the proposal has been
accepted.
Aparajita Singh 于2022年3月14日周一 17:47写道：
>
> Thanks for reviewing and voting. Can the proposal be accepted now?
>
> On Mon, 14 Mar 2022 at 06:
Thanks Hang.
Closing this vote with 3 (+1) bindings and 0 (-1).
On Mon, 14 Mar 2022 at 19:01, Hang Chen wrote:
> Hi Aparajita,
> Thanks for you contribution. This proposal has 3 (+1) bindings and
> 0 (-1). You can close this vote now and the proposal has been
> accepted.
>
> Aparajita Singh
Thanks @Mattison.
Yes, It's a long term fix solution, the protocol changes need to upgrade
the broker and client
and we can only apply the protocol changes to a major release.
I think Zixuan is trying to find a short-term fix without protocol changes.
Penghui
On Mon, Mar 14, 2022 at 5:59 PM mat
+1 (binding)
- Verify the checksum and signature
- Run perf produce and consume.
Best,
Hang
r...@apache.org 于2022年3月14日周一 11:28写道：
>
> +1 (non-bindig)
>
> - Verify the checksum
> - Run Action CI for all test case
>
> --
> Thanks
> Xiaolong Ran
>
> Hiroyuki Sakai 于2022年3月11日周五 14:24写道：
>
> > +1
+1 (binding)
- Checked the signature
- Build from the source code
- Run tests
Penghui
On Tue, Mar 15, 2022 at 9:22 AM Hang Chen wrote:
> +1 (binding)
>
> - Verify the checksum and signature
> - Run perf produce and consume.
>
> Best,
> Hang
>
> r...@apache.org 于2022年3月14日周一 11:28写道：
> >
> > +
wynan commented on issue #409:
URL: https://github.com/apache/pulsar-manager/issues/409#issuecomment-1067482259
I'm wondering if this PR is still viable? I'm looking to use Pulsar to
implement a data mesh and would love to expose the Schema registry more in the
manager.
--
This is an au
Hi Pulsar community,
Thank you for your vote. Is this proposal acceptable?
Thanks,
Zixuan
Zike Yang 于2022年3月14日周一 14:26写道：
> +1
>
> Thanks,
> Zike Yang
>
> On Mon, Mar 14, 2022 at 11:27 AM r...@apache.org
> wrote:
> >
> > +1
> >
> > --
> > Thanks
> > Xiaolong Ran
> >
> > Hang Chen 于2022年3月14
Thanks to everyone for the validation
Close this vote:
4 +1(binding)
- Matteo Merli
- Hiroyuki Sakai
- Hang Chen
- Penghui Li
1 +1(non-binding)
- Xiaolong Ran
Best,
Rui Fu
在 2022年3月15日 +0800 09:57，PengHui Li ，写道：
> +1 (binding)
>
> - Checked the signature
> - Build from the source code
> - R
michaeljmarshall opened a new issue #20:
URL: https://github.com/apache/pulsar-site/issues/20
When I clone this git repo on a MacOS, I get the following output/error:
```
mmarshall-rmbp16:apache michaelmarshall$ git clone
g...@github.com:apache/pulsar-site.git
Cloning into 'pul
michaeljmarshall opened a new pull request #21:
URL: https://github.com/apache/pulsar-site/pull/21
See https://github.com/apache/pulsar/pull/14610 and
https://github.com/apache/pulsar/pull/14610#issuecomment-1067510855 for context.
Adding some detail to the reporting a vulnerability
michaeljmarshall commented on pull request #21:
URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1067575643
I verified that this "looks" correct. Here are screenshots:
https://user-images.githubusercontent.com/47911938/158312064-247f81d3-3d47-47cd-a7c0-9077aa94ddc5.png";>
there is another problem: https://github.com/apache/pulsar/issues/14690
fix
for initialize-cluster-metadata: https://github.com/apache/pulsar/pull/14686
-- --
??:
Hi Zixuan,
This proposal has 3 (+1) bindings and 0 (-1) and has stayed open for
at least 48 hours. You can close this vote now and the proposal has
been accepted.
Thanks,
Zike Yang
On Tue, Mar 15, 2022 at 10:50 AM Zixuan Liu wrote:
>
> Hi Pulsar community,
>
> Thank you for your vote. Is this p
Anonymitaet commented on pull request #21:
URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1067627368
I think one place (below) is enough since we do not want duplicated content,
right? @D-2-Ed @DaveDuggins
