[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

[GitBox]

massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825664237



##########
File path: src/Consumer.cc
##########
@@ -225,14 +214,17 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker {
   ~ConsumerReceiveWorker() {}
   void Execute() {
     pulsar_result result;
+    pulsar_message_t *rawMessage;
     if (timeout > 0) {
-      result = pulsar_consumer_receive_with_timeout(this->cConsumer, 
&(this->cMessage), timeout);
+      result = pulsar_consumer_receive_with_timeout(this->cConsumer.get(), 
&rawMessage, timeout);
     } else {
-      result = pulsar_consumer_receive(this->cConsumer, &(this->cMessage));
+      result = pulsar_consumer_receive(this->cConsumer.get(), &rawMessage);
     }
 
     if (result != pulsar_result_Ok) {
-      SetError(std::string("Failed to received message ") + 
pulsar_result_str(result));
+      SetError(std::string("Failed to consumer receive message: ") + 
pulsar_result_str(result));

Review comment:
       ```suggestion
         SetError(std::string("Consumer failed to receive message: ") + 
pulsar_result_str(result));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org