[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #212: Fix setting pulsar manager credentials and disable pulsar manager by default

2022-01-26 Thread GitBox
lhotari opened a new pull request #212: URL: https://github.com/apache/pulsar-helm-chart/pull/212 Fixes #31 Fixes #108 ### Motivation - configuration for pulsar_manager is outdated and doesn't work ### Modifications - disable pulsar_manager by default because

[GitHub] [pulsar-helm-chart] lhotari commented on issue #31: Param pulsar_manager.admin.user/pulsar_manager.admin.password used in the wrong place

2022-01-26 Thread GitBox
lhotari commented on issue #31: URL: https://github.com/apache/pulsar-helm-chart/issues/31#issuecomment-1021983805 Please review PR #212, it should fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-helm-chart] lhotari commented on issue #108: Pulsar manager always uses default user/password

2022-01-26 Thread GitBox
lhotari commented on issue #108: URL: https://github.com/apache/pulsar-helm-chart/issues/108#issuecomment-1021984024 Please review PR #212, it should fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #212: Fix setting pulsar manager credentials and disable pulsar manager by default

2022-01-26 Thread GitBox
lhotari commented on pull request #212: URL: https://github.com/apache/pulsar-helm-chart/pull/212#issuecomment-1021994602 Actually this pulsar manager business is more complex than I thought. I'm giving up on the fix. There's supervisord in the Dockerfile with environment name mapp

[GitHub] [pulsar-helm-chart] lhotari closed pull request #212: Fix setting pulsar manager credentials and disable pulsar manager by default

2022-01-26 Thread GitBox
lhotari closed pull request #212: URL: https://github.com/apache/pulsar-helm-chart/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #213: Don't enable pulsar manager by default

2022-01-26 Thread GitBox
lhotari opened a new pull request #213: URL: https://github.com/apache/pulsar-helm-chart/pull/213 ### Motivation - because of security reasons - it increases the attack surface - it's an unnecessary feature for most users - wasted resource consumption -- This is an aut

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-26 Thread Zike Yang
Thanks for your participation and your great efforts to move this forward! Close the vote with 3 (+1) bindings and 2 (+1) non-bindings. Thanks, Zike On Wed, Jan 26, 2022 at 3:54 PM PengHui Li wrote: > > +1 (binding) > > Regards, > Penghui > > On Wed, Jan 26, 2022 at 12:17 PM Michael Marshall >

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022150908 It's possible that the Zookeeper issue is simply caused by the probe getting stuck. The changes in #179 fix the issue for 1.20+ . I'll send a separate PR to address

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #214: Wrap Zookeeper probe script with timeout command

2022-01-26 Thread GitBox
lhotari opened a new pull request #214: URL: https://github.com/apache/pulsar-helm-chart/pull/214 ### Motivation Run Zookeeper probes with timeout command so that the probe doesn't continue running indefinitely. It seems that the probe will get stuck because of https://issues

[GitHub] [pulsar-helm-chart] lhotari merged pull request #214: Wrap Zookeeper probe script with timeout command

2022-01-26 Thread GitBox
lhotari merged pull request #214: URL: https://github.com/apache/pulsar-helm-chart/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022189980 Rebased after #214 changes. Let's see if the Zookeeper TLS tests pass now. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022201745 All tests pass now. I'll inform about this [on the dev mailing list thread](https://lists.apache.org/thread/619tpn6q5xbbhngwsmhtq3121vhjxpt4). -- This is an automate

[GitHub] [pulsar-helm-chart] lhotari merged pull request #211: Add -XX:+ExitOnOutOfMemoryError to Zookeeper's PULSAR_GC parameters

2022-01-26 Thread GitBox
lhotari merged pull request #211: URL: https://github.com/apache/pulsar-helm-chart/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari merged pull request #213: Don't enable pulsar manager by default

2022-01-26 Thread GitBox
lhotari merged pull request #213: URL: https://github.com/apache/pulsar-helm-chart/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari merged pull request #118: Consistently use the 'pulsar.matchLabels' template for matching

2022-01-26 Thread GitBox
lhotari merged pull request #118: URL: https://github.com/apache/pulsar-helm-chart/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari closed pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari closed pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022207389 Closing and re-opening to run the tests one more time to see that the problem is fixed. -- This is an automated message from the Apache Git Service. To respond to th

Re: upcoming change: Apache Pulsar Helm Chart switching from Pulsar 2.7.4 version to 2.8.2; known issue with ZK when TLS is enabled

2022-01-26 Thread Lari Hotari
UPDATE: There's now a workaround for the issue with Zookeeper in Pulsar 2.8.x . The fix was to add timeout handling for the Zookeeper probes, the PR is https://github.com/apache/pulsar-helm-chart/pull/214. An earlier PR https://github.com/apache/pulsar-helm-chart/pull/179 added probe timeouts,

Re: upcoming change: Apache Pulsar Helm Chart switching from Pulsar 2.7.4 version to 2.8.2; known issue with ZK when TLS is enabled

2022-01-26 Thread Enrico Olivelli
great work Lari ! what about upgrading to 2.9.1 and not to 2.8.2 ? We are VOTing for 2.9.2 and 2.10 will be shipped soon isn't 2.8.2 quite old at this point ? Enrico Il giorno mer 26 gen 2022 alle ore 14:52 Lari Hotari ha scritto: > > UPDATE: > There's now a workaround for the issue with Zooke

Re: upcoming change: Apache Pulsar Helm Chart switching from Pulsar 2.7.4 version to 2.8.2; known issue with ZK when TLS is enabled

2022-01-26 Thread Lari Hotari
The ZK TLS seem to continue to hang. I re-ran the tests once more and the tests are hanging. https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022207389 > what about upgrading to 2.9.1 and not to 2.8.2 ? > We are VOTing for 2.9.2 and 2.10 will be shipped soon I'm expecting that

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #200: Use appVersion as default tag for Pulsar images

2022-01-26 Thread GitBox
lhotari commented on pull request #200: URL: https://github.com/apache/pulsar-helm-chart/pull/200#issuecomment-1022251071 @sijie please review this PR since it's based [on your suggestion the dev mailing list](https://lists.apache.org/thread/bgkvcyt1qq6h67p2k8xwp89xlncbqn3d). I might hav

[GitHub] [pulsar-dotpulsar] RagingKore commented on pull request #86: [WIP] Multi-topics consumer and partitioned consumer support

2022-01-26 Thread GitBox
RagingKore commented on pull request #86: URL: https://github.com/apache/pulsar-dotpulsar/pull/86#issuecomment-1022337001 Hi, I was going through the PR so what's the status of this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar-dotpulsar] RagingKore commented on pull request #86: [WIP] Multi-topics consumer and partitioned consumer support

2022-01-26 Thread GitBox
RagingKore commented on pull request #86: URL: https://github.com/apache/pulsar-dotpulsar/pull/86#issuecomment-1022339985 Quick questions: * why change MessageId class to IMessageId? * why do we need Nito.AsyncEx? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #213: Don't enable pulsar manager by default

2022-01-26 Thread GitBox
michaeljmarshall commented on pull request #213: URL: https://github.com/apache/pulsar-helm-chart/pull/213#issuecomment-1022359937 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #212: Fix setting pulsar manager credentials and disable pulsar manager by default

2022-01-26 Thread GitBox
michaeljmarshall commented on pull request #212: URL: https://github.com/apache/pulsar-helm-chart/pull/212#issuecomment-1022367572 I think the right first step is probably to remove the pulsar-manager dependency on supervisord. -- This is an automated message from the Apache Git Service

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-26 Thread Michael Marshall
Hi Zike, Based on our current voting rules, I believe we need to leave the vote open for at least 17 more hours. There has been discussion on the dev list about changing this rule, but I don't believe we have reached any conclusions yet. Thanks, Michael On Wed, Jan 26, 2022 at 6:04 AM Zike Yang

[GitHub] [pulsar-dotpulsar] RagingKore commented on pull request #86: [WIP] Multi-topics consumer and partitioned consumer support

2022-01-26 Thread GitBox
RagingKore commented on pull request #86: URL: https://github.com/apache/pulsar-dotpulsar/pull/86#issuecomment-1022397025 My suggestion would be to simply had a Topic property to the `MessageId` and then add a new method to the consumer `public static Task GetTopicLatestMessageIds(Topic

[GitHub] [pulsar-dotpulsar] RagingKore edited a comment on pull request #86: [WIP] Multi-topics consumer and partitioned consumer support

2022-01-26 Thread GitBox
RagingKore edited a comment on pull request #86: URL: https://github.com/apache/pulsar-dotpulsar/pull/86#issuecomment-1022397025 My suggestion would be to simply had a `Topic` property to the `MessageId` and then add a new method to the consumer `public static Task GetTopicLatestMessageI

Re: [Discuss] Create new issues to SDKs in different languages

2022-01-26 Thread Michael Marshall
We have a Client Features Matrix page on the GitHub wiki [0]. This seems like a helpful and relevant resource for this thread. It is only in a Google Sheet right now, though. Maybe the owners of the Google doc would consider contributing it to the website? The website references this matrix on th

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #215: [CI] Collect and upload k8s logs on failure

2022-01-26 Thread GitBox
lhotari opened a new pull request #215: URL: https://github.com/apache/pulsar-helm-chart/pull/215 - collect and upload k8s logs when the job fails or gets cancelled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022412577 I'm hoping to get more logs from the failure after #215 changes are in place in CI. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-dotpulsar] RagingKore commented on pull request #86: [WIP] Multi-topics consumer and partitioned consumer support

2022-01-26 Thread GitBox
RagingKore commented on pull request #86: URL: https://github.com/apache/pulsar-dotpulsar/pull/86#issuecomment-1022416301 On the `AutoUpdatePartitions` feature. IMHO this behaviour should be native and always automatically be handled internally while raising an event to allow the use

[GitHub] [pulsar-helm-chart] lhotari merged pull request #215: [CI] Collect and upload k8s logs on failure

2022-01-26 Thread GitBox
lhotari merged pull request #215: URL: https://github.com/apache/pulsar-helm-chart/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #216: [CI] Fix issue with k8s log collection

2022-01-26 Thread GitBox
lhotari opened a new pull request #216: URL: https://github.com/apache/pulsar-helm-chart/pull/216 - slash needs to be replaced with underscore - fixes small issue in #215 solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #216: [CI] Fix issue with k8s log collection

2022-01-26 Thread GitBox
lhotari commented on pull request #216: URL: https://github.com/apache/pulsar-helm-chart/pull/216#issuecomment-1022489948 fixes this issue: https://github.com/apache/pulsar-helm-chart/runs/4955444589?check_suite_focus=true#step:7:6 -- This is an automated message from the Apache Git Ser

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #216: [CI] Fix issue with k8s log collection

2022-01-26 Thread GitBox
lhotari edited a comment on pull request #216: URL: https://github.com/apache/pulsar-helm-chart/pull/216#issuecomment-1022489948 fixes this issue: https://github.com/apache/pulsar-helm-chart/runs/4955444589?check_suite_focus=true#step:7:6 ``` Run source .ci/helm.sh Collecting

[GitHub] [pulsar-helm-chart] lhotari merged pull request #216: [CI] Fix issue with k8s log collection

2022-01-26 Thread GitBox
lhotari merged pull request #216: URL: https://github.com/apache/pulsar-helm-chart/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #217: [CI] Tolerate errors when collecting k8s logs in CI

2022-01-26 Thread GitBox
lhotari opened a new pull request #217: URL: https://github.com/apache/pulsar-helm-chart/pull/217 - The log collection failed after a command failed. - tolerate errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #217: [CI] Tolerate errors when collecting k8s logs in CI

2022-01-26 Thread GitBox
lhotari commented on pull request #217: URL: https://github.com/apache/pulsar-helm-chart/pull/217#issuecomment-1022555718 issue was ``` Collecting k8s logs to /tmp/k8s-logs Error from server (BadRequest): container "pulsar-ci-bookie" in pod "pulsar-ci-bookie-0" is waiting to start

[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #217: [CI] Tolerate errors when collecting k8s logs in CI

2022-01-26 Thread GitBox
michaeljmarshall merged pull request #217: URL: https://github.com/apache/pulsar-helm-chart/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [pulsar-helm-chart] lhotari closed pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari closed pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-26 Thread Zike Yang
Hi Michael, Sorry, I forgot about it. Sorry for my mistake. Thanks for your correction. I will stay this vote open. Thanks, Zike On Thu, Jan 27, 2022 at 12:31 AM Michael Marshall wrote: > > Hi Zike, > > Based on our current voting rules, I believe we need to leave the vote > open for at le

[GitHub] [pulsar-helm-chart] tuteng commented on a change in pull request #170: The Token management function is not supported when pulsar Manager is deployed using helm Charts.

2022-01-26 Thread GitBox
tuteng commented on a change in pull request #170: URL: https://github.com/apache/pulsar-helm-chart/pull/170#discussion_r793221793 ## File path: charts/pulsar/templates/pulsar-manager-configmap.yaml ## @@ -27,5 +27,10 @@ metadata: {{- include "pulsar.standardLabels" . | ni

[GitHub] [pulsar-helm-chart] lhotari closed pull request #190: Bump to Pulsar 2.8.2

2022-01-26 Thread GitBox
lhotari closed pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

Re: [Discuss] Create new issues to SDKs in different languages

2022-01-26 Thread Yu
Hi Michael, Thanks for raising this up. > It is only in a Google Sheet right now, though. Maybe the owners of the Google doc would consider contributing it to the website? This google sheet [1] has been already contributed to our community. Everyone has access to view and comment on it. > The w