great work Lari ! what about upgrading to 2.9.1 and not to 2.8.2 ? We are VOTing for 2.9.2 and 2.10 will be shipped soon
isn't 2.8.2 quite old at this point ? Enrico Il giorno mer 26 gen 2022 alle ore 14:52 Lari Hotari <lhot...@apache.org> ha scritto: > > UPDATE: > There's now a workaround for the issue with Zookeeper in Pulsar 2.8.x . > > The fix was to add timeout handling for the Zookeeper probes, the PR is > https://github.com/apache/pulsar-helm-chart/pull/214. > An earlier PR https://github.com/apache/pulsar-helm-chart/pull/179 added > probe timeouts, but this only works since Kubernetes 1.20. > > Please proceed to review https://github.com/apache/pulsar-helm-chart/pull/190 > which upgrades Pulsar images to 2.8.2 and bumps the Chart version to 2.8.0 . > > The change to make Pulsar image version default to Chart's appVersion is in a > separate PR https://github.com/apache/pulsar-helm-chart/pull/200 . That > change was earlier requested by Sijie in this email thread. I'd appreciate > feedback and reviews on that change too. > > I'd like to suggest that we go ahead in reviewing and merging > https://github.com/apache/pulsar-helm-chart/pull/190 asap so that we can > finally move to Pulsar 2.8.x in the Pulsar Helm Chart. > > BR, > Lari > > > On 2022/01/12 12:52:47 Lari Hotari wrote: > > Hi Sijie, > > > > Thanks for the suggestions. > > > > > That means: > > > > > > > 1. We should have a separate `version` from `appVersion`. > > > > 2. We should use the Pulsar image version as the `appVersion`. > > > > 3. It is okay to only update broker and proxy images version and leave > > > zookeeper and bookkeeper version unchanged. > > > > > > > I believe 1.) is already how we handle apache/pulsar-helm-chart. version of > > the chart is independent of appVersion. > > For 2.) I have created https://github.com/apache/pulsar-helm-chart/pull/200 > > . @si...@apache.org <si...@apache.org> is that what you meant? Please > > review the PR. > > 3.) I guess this is more about addition documentation? Are there any > > changes that need to be made in the Apache Pulsar Helm Chart to support > > this? > > > > BR, > > > > Lari > > > > > > On Fri, Jan 7, 2022 at 2:58 AM Sijie Guo <guosi...@gmail.com> wrote: > > > > > The fundamental problem I see is that we don't have a proper helm chart > > > release and we don't have good versioning guidance. > > > > > > Chart should have its own version, which is independent of the Pulsar > > > version. > > > > > > Also, we need to provide a guide to the community - most of the time, you > > > don't need to upgrade zookeeper and bookkeeper. Because these two > > > components are rarely changed. > > > > > > That means: > > > > > > 1. We should have a separate `version` from `appVersion`. > > > 2. We should use the Pulsar image version as the `appVersion`. > > > 3. It is okay to only update broker and proxy images version and leave > > > zookeeper and bookkeeper version unchanged. > > > > > > That's probably not the final guide. But at least, we can have something > > > to > > > get started to formalize the process. This guide will then help us handle > > > such situations better. > > > > > > - Sijie > > > > > > On Wed, Jan 5, 2022 at 6:00 AM 陳智弘 <thomasec...@gmail.com> wrote: > > > > > > > Hi everyone, > > > > > > > > From my side, I think currently merging the request without regarding > > > the > > > > known issue and announcing this information on the website is a good > > > > option. > > > > > > > > < > > > > > > > http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail > > > > > > > > > 不含病毒。www.avg.com > > > > < > > > > > > > http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail > > > > > > > > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > > > > > > Lari Hotari <lhot...@apache.org> 於 2022年1月5日 週三 下午9:04寫道： > > > > > > > > > Reminder: we need to decide about the developement of Apache Pulsar > > > Helm > > > > > chart. > > > > > Please reply to the email or review > > > > > https://github.com/apache/pulsar-helm-chart/pull/190 . > > > > > That PR is blocked since a decision must be made whether it's fine to > > > > make > > > > > the change, although there's a known issue in Zookeeper when TLS is > > > > > enabled. > > > > > The issue is ZOOKEEPER-3988 / > > > > > https://github.com/apache/pulsar/issues/11070 . > > > > > The bug currently only impacts TLS since the change > > > > > https://github.com/apache/pulsar-helm-chart/pull/180 switched > > > > > to use NIOServerCnxnFactory for Zookeeper. NIOServerCnxnFactory > > > > > doesn't > > > > > support TLS and the impacted NettyServerCnxnFactory must be used for > > > TLS. > > > > > > > > > > How do we handle the decision? Can we proceed in merging > > > > > https://github.com/apache/pulsar-helm-chart/pull/190 regardless of the > > > > > known issue? > > > > > > > > > > BR, > > > > > Lari > > > > > > > > > > On Mon, Jan 3, 2022 at 4:39 PM Lari Hotari <lhot...@apache.org> wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > There's an upcoming change in the Apache Pulsar Helm chart to > > > > > > finally > > > > > > switch to Pulsar 2.8.x, more specifically to Apache Pulsar version > > > > 2.8.2 > > > > > . > > > > > > The latest Apache Pulsar Helm Chart release uses the Apache Pulsar > > > > 2.7.4 > > > > > > image. > > > > > > > > > > > > The pull request to switch to Apache Pulsar image version 2.8.2 is > > > > > current > > > > > > in review: > > > > > > https://github.com/apache/pulsar-helm-chart/pull/190 > > > > > > > > > > > > There's a known issue that Zookeeper TLS isn't stable because of > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3988 (also reported > > > in > > > > > > apache/pulsar as https://github.com/apache/pulsar/issues/11070) . > > > > > > The fix https://github.com/apache/zookeeper/pull/1770 is planned for > > > > > > Zookeeper 3.7.1 version. > > > > > > There's a workaround in the Apache Pulsar Helm chart when TLS isn't > > > > > > enabled for Zookeeper. That was added by > > > > > > https://github.com/apache/pulsar-helm-chart/pull/180 . > > > > > > However, the workaround cannot be applied when TLS is enabled for > > > > > > Zookeeper. > > > > > > > > > > > > Should we postpone switching to Apache Pulsar 2.8.2 in the Helm > > > > > > chart > > > > > > until there's a fix for ZOOKEEPER-3988 / > > > > > > https://github.com/apache/pulsar/issues/11070 ? > > > > > > > > > > > > BR, > > > > > > Lari > > > > > > > > > > > > > > > > > > > >
