Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Enrico Olivelli
1 (binding) Enrico Il giorno mer 22 dic 2021 alle ore 03:39 mattison chao < mattisonc...@gmail.com> ha scritto: > +1 > > On Wed, 22 Dec 2021 at 07:46, Matteo Merli wrote: > > > This is the voting thread for PIP-120. It will stay open for at least > 48h. > > > > https://github.com/apache/pulsar/

[GitHub] [pulsar-manager] sourabhaggrawal opened a new pull request #435: Fix for Sidebar items not visible to admin and superadmin

2021-12-22 Thread GitBox
sourabhaggrawal opened a new pull request #435: URL: https://github.com/apache/pulsar-manager/pull/435 ### Motivation *All newly added sidebar items (Roles,Users etc) are not visible to superadmin. Also when admin user login, only Token tab is visible to them.* ### M

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-22 Thread Zike Yang
> We can avoid confusion by only attempting to create the subscription > when `initSubscriptionName` is not `null`. As a result, this PIP > wouldn't change the behavior for current implementations. I think there is an issue with the current behavior. When the init subscription is not created before

Re: [VOTE] Apache Pulsar 2.8.2 candidate 2

2021-12-22 Thread Nicolò Boschi
+1 (non binding) Checks: - Checksum and signatures - Apache Rat check passes - Compile from source w JDK8 - Build docker image from source - Run Pulsar standalone and produce-consume from CLI - Verified Log4J inside lib/ -rw-r--r-- 1 root root 208235 Jan 22 2020 org.apache.logging.log4j-log4j-

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Christophe Bornet
+1 Le mer. 22 déc. 2021 à 00:46, Matteo Merli a écrit : > This is the voting thread for PIP-120. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13306 > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory >

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread ZhangJian He
+1 Christophe Bornet 于2021年12月22日周三 17:38写道: > +1 > > Le mer. 22 déc. 2021 à 00:46, Matteo Merli a écrit : > > > This is the voting thread for PIP-120. It will stay open for at least > 48h. > > > > https://github.com/apache/pulsar/issues/13306 > > > > > > > > ## Motivation > > > > In P

Re: [VOTE] Pulsar Release 2.7.4 Candidate 2

2021-12-22 Thread PengHui Li
+1 (binding) - check signatures - build from sources - verify Cassandra connector - verify functions Thanks for the great work. Penghui On Tue, Dec 21, 2021 at 7:28 PM Enrico Olivelli wrote: > +1 (binding) > > - built from sources, JDK8 in MacOS > - run pulsar standalone, smoke tests > - veri

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread PengHui Li
+1 Penghui On Wed, Dec 22, 2021 at 6:57 PM ZhangJian He wrote: > +1 > > Christophe Bornet 于2021年12月22日周三 17:38写道: > > > +1 > > > > Le mer. 22 déc. 2021 à 00:46, Matteo Merli a écrit : > > > > > This is the voting thread for PIP-120. It will stay open for at least > > 48h. > > > > > > https://

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-22 Thread PengHui Li
I think we can create a consumer with the DLQ init subscription and then close the consumer? This will make the implementation easier. Penghui On Wed, Dec 22, 2021 at 4:49 PM Zike Yang wrote: > > We can avoid confusion by only attempting to create the subscription > > when `initSubscriptionName

Re: [VOTE] PIP-123: Introduce Pulsar metadata CLI tool

2021-12-22 Thread PengHui Li
+1 Penghui On Wed, Dec 22, 2021 at 3:31 PM Enrico Olivelli wrote: > very good > > Enrico > > Il giorno mer 22 dic 2021 alle ore 03:37 mattison chao < > mattisonc...@gmail.com> ha scritto: > > > +1 > > > > On Wed, 22 Dec 2021 at 07:59, Matteo Merli wrote: > > > > > This is the voting thread for

Re: [VOTE] PIP-117: Change Pulsar standalone defaults

2021-12-22 Thread PengHui Li
+1 Penghui On Wed, Dec 22, 2021 at 7:49 AM Matteo Merli wrote: > This is the voting thread for PIP-117. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13302 > > > > ## Motivation > > Pulsar standalone is the "Pulsar in a box" version of a Pulsar cluster, >

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread PengHui Li
+1 Penghui On Wed, Dec 22, 2021 at 7:23 AM Matteo Merli wrote: > This is the voting thread for PIP-119. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13305 > > --- > > ## Motivation > > The consistent hashing implementation to uniformly assign keys to c

Re: [VOTE] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-22 Thread PengHui Li
+1 Penghui On Wed, Dec 22, 2021 at 7:22 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > Following the discussion, I have updated the proposal to also include > the deprecation and renaming of the config setting name to > `metadataSessionExpiredPolicy`. > > > > ---

Re: [VOTE] PIP-117: Change Pulsar standalone defaults

2021-12-22 Thread ZhangJian He
+1 PengHui Li 于2021年12月22日周三 19:33写道: > +1 > > Penghui > > On Wed, Dec 22, 2021 at 7:49 AM Matteo Merli wrote: > > > This is the voting thread for PIP-117. It will stay open for at least > 48h. > > > > https://github.com/apache/pulsar/issues/13302 > > > > > > > > ## Motivation > > > > Puls

Re: [VOTE] PIP-117: Change Pulsar standalone defaults

2021-12-22 Thread Hang Chen
+1 Thanks, Hang ZhangJian He 于2021年12月22日周三 20:02写道: > > +1 > > PengHui Li 于2021年12月22日周三 19:33写道: > > > +1 > > > > Penghui > > > > On Wed, Dec 22, 2021 at 7:49 AM Matteo Merli wrote: > > > > > This is the voting thread for PIP-117. It will stay open for at least > > 48h. > > > > > > https://g

Re: [VOTE] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-22 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月22日周三 19:34写道: > > +1 > > Penghui > > On Wed, Dec 22, 2021 at 7:22 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13304 > > > > Following the discussion, I have updated the proposal to also include > > the deprecation and renaming of the

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月22日周三 19:33写道: > > +1 > > Penghui > > On Wed, Dec 22, 2021 at 7:23 AM Matteo Merli wrote: > > > This is the voting thread for PIP-119. It will stay open for at least 48h. > > > > https://github.com/apache/pulsar/issues/13305 > > > > --- > > > > ## Mot

Re: [VOTE] PIP-123: Introduce Pulsar metadata CLI tool

2021-12-22 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月22日周三 19:33写道: > > +1 > > Penghui > > On Wed, Dec 22, 2021 at 3:31 PM Enrico Olivelli wrote: > > > very good > > > > Enrico > > > > Il giorno mer 22 dic 2021 alle ore 03:37 mattison chao < > > mattisonc...@gmail.com> ha scritto: > > > > > +1 > > > > > > On We

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月22日周三 19:28写道: > > +1 > > Penghui > > On Wed, Dec 22, 2021 at 6:57 PM ZhangJian He wrote: > > > +1 > > > > Christophe Bornet 于2021年12月22日周三 17:38写道: > > > > > +1 > > > > > > Le mer. 22 déc. 2021 à 00:46, Matteo Merli a écrit : > > > > > > > This is the voti

OWASP dependencies check on active branches

2021-12-22 Thread Nicolò Boschi
Hello everyone, I created a couple of pull requests in order to run a periodic check on Pulsar active branches. In this way we can proactively update dependencies whenever is needed (for fixing CVE's purpose) The first one [0] is to make the check pass on branch-2.8 The second one [1] is to make

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Michael Marshall
+1 - Michael On Wed, Dec 22, 2021 at 6:10 AM Hang Chen wrote: > > +1 > > Thanks, > Hang > > PengHui Li 于2021年12月22日周三 19:28写道: > > > > +1 > > > > Penghui > > > > On Wed, Dec 22, 2021 at 6:57 PM ZhangJian He wrote: > > > > > +1 > > > > > > Christophe Bornet 于2021年12月22日周三 17:38写道: > > > > > >

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread Michael Marshall
+1 - Michael On Wed, Dec 22, 2021 at 6:09 AM Hang Chen wrote: > > +1 > > Thanks, > Hang > > PengHui Li 于2021年12月22日周三 19:33写道: > > > > +1 > > > > Penghui > > > > On Wed, Dec 22, 2021 at 7:23 AM Matteo Merli wrote: > > > > > This is the voting thread for PIP-119. It will stay open for at least

Re: OWASP dependencies check on active branches

2021-12-22 Thread Lari Hotari
Good work Nicolò! It's great to have OWASP dependency check handled for all active branches. -Lari On Wed, Dec 22, 2021 at 5:05 PM Nicolò Boschi wrote: > Hello everyone, > > I created a couple of pull requests in order to run a periodic check on > Pulsar active branches. In this way we can proa

[GitHub] [pulsar-helm-chart] sdwerwed edited a comment on pull request #127: Antiaffinity with zone topology for high availability

2021-12-22 Thread GitBox
sdwerwed edited a comment on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-859123386 Hello @wolfstudy, @sijie, can you have a look at this PR, let me know if any other action is required from my side. -- This is an automated message from the Ap

[GitHub] [pulsar-helm-chart] sdwerwed commented on pull request #127: Antiaffinity with zone topology for high availability

2021-12-22 Thread GitBox
sdwerwed commented on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-999727380 Hello @wolfstudy, @sijie, can you have a look at this PR, let me know if any other action is required from my side. -- This is an automated message from the

[GitHub] [pulsar-helm-chart] sdwerwed removed a comment on pull request #127: Antiaffinity with zone topology for high availability

2021-12-22 Thread GitBox
sdwerwed removed a comment on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-859123386 Hello @wolfstudy, @sijie, can you have a look at this PR, let me know if any other action is required from my side. -- This is an automated message from the A

Re: [PR] Pulsar non root docker image

2021-12-22 Thread Michael Marshall
Thanks for raising this important topic, Enrico. > Basically if you are running as non root, you cannot add tools on demand, > so we need to add basic tools, like netstat/vim/unzip otherwise when > you have a problem you are trapped. I agree that running as a non root user presents challenges

Re: WebSite build CI job does work - blocker for announcing release !

2021-12-22 Thread Dave Fisher
Hi - A WebSite Build CI Job just completed. Please check that it created the new docs. I see the release notes for 2.9.1 - https://pulsar.apache.org/en/release-notes/ Regards, Dave > On Dec 21, 2021, at 11:33 PM, Nicolò Boschi wrote: > > I think the problem is that it times out (currently th

Re: WebSite build CI job does work - blocker for announcing release !

2021-12-22 Thread Enrico Olivelli
Thanks Dave, I don't see 2.9.1 in the download page. Did I miss to update some files? Enrico Il Mer 22 Dic 2021, 21:19 Dave Fisher ha scritto: > Hi - > > A WebSite Build CI Job just completed. Please check that it created the > new docs. > > I see the release notes for 2.9.1 - > https://pulsar.

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread Enrico Olivelli
+1 (binding) Enrico Il Mer 22 Dic 2021, 16:59 Michael Marshall ha scritto: > +1 > > - Michael > > On Wed, Dec 22, 2021 at 6:09 AM Hang Chen wrote: > > > > +1 > > > > Thanks, > > Hang > > > > PengHui Li 于2021年12月22日周三 19:33写道: > > > > > > +1 > > > > > > Penghui > > > > > > On Wed, Dec 22, 2021

Re: [VOTE] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-22 Thread Enrico Olivelli
+1 (binding) Enrico Il Mer 22 Dic 2021, 13:09 Hang Chen ha scritto: > +1 > > Thanks, > Hang > > PengHui Li 于2021年12月22日周三 19:34写道: > > > > +1 > > > > Penghui > > > > On Wed, Dec 22, 2021 at 7:22 AM Matteo Merli wrote: > > > > > https://github.com/apache/pulsar/issues/13304 > > > > > > Followi

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Enrico Olivelli
+1 (binding) Enrico Il Mer 22 Dic 2021, 16:58 Michael Marshall ha scritto: > +1 > > - Michael > > On Wed, Dec 22, 2021 at 6:10 AM Hang Chen wrote: > > > > +1 > > > > Thanks, > > Hang > > > > PengHui Li 于2021年12月22日周三 19:28写道: > > > > > > +1 > > > > > > Penghui > > > > > > On Wed, Dec 22, 2021

Re: WebSite build CI job does work - blocker for announcing release !

2021-12-22 Thread Dave Fisher
See this PR for 2.8.1 - https://github.com/apache/pulsar/pull/12089/files > On Dec 22, 2021, at 12:48 PM, Enrico Olivelli wrote: > > Thanks Dave, > I don't see 2.9.1 in the download page. > Did I miss to update some files? > > Enrico > > Il Mer 22 Dic 2021, 21:19 Dave Fisher ha scritto: > >>

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-22 Thread Michael Marshall
> I think there is an issue with the current behavior. When the init > subscription > is not created before creating deadLetterProducer, it may result in the > loss of messages. > And this is not the expected behavior. I'm not sure I agree with this assertion. The default in Pulsar is that a topic

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-22 Thread Matteo Merli
> What if we extended the `CommandProducer` command to add a > `create_subscription` field? Then, any time a topic is auto > created and this field is true, the broker would auto create a > subscription. There are some details to work out, but I think this > feature would fulfill the needs of this

Re: [VOTE] PIP-120: Enable client memory limit by default

2021-12-22 Thread Sijie Guo
+1 On Wed, Dec 22, 2021 at 2:08 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Mer 22 Dic 2021, 16:58 Michael Marshall ha > scritto: > > > +1 > > > > - Michael > > > > On Wed, Dec 22, 2021 at 6:10 AM Hang Chen wrote: > > > > > > +1 > > > > > > Thanks, > > > Hang > > > > > > PengHui

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread Sijie Guo
+1 On Tue, Dec 21, 2021 at 3:23 PM Matteo Merli wrote: > This is the voting thread for PIP-119. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13305 > > --- > > ## Motivation > > The consistent hashing implementation to uniformly assign keys to consumers

Re: [VOTE] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-22 Thread Sijie Guo
+1 On Tue, Dec 21, 2021 at 3:22 PM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > Following the discussion, I have updated the proposal to also include > the deprecation and renaming of the config setting name to > `metadataSessionExpiredPolicy`. > > > > --- > ## Mot

Re: [VOTE] PIP-123: Introduce Pulsar metadata CLI tool

2021-12-22 Thread Sijie Guo
+1 On Tue, Dec 21, 2021 at 3:59 PM Matteo Merli wrote: > This is the voting thread for PIP-123. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13346 > > > - > ## Motivation > > For a very long time, we have included a CLI command to start the ZooKeeper >

Re: [VOTE] PIP-117: Change Pulsar standalone defaults

2021-12-22 Thread Sijie Guo
+1 On Tue, Dec 21, 2021 at 3:49 PM Matteo Merli wrote: > This is the voting thread for PIP-117. It will stay open for at least 48h. > > https://github.com/apache/pulsar/issues/13302 > > > > ## Motivation > > Pulsar standalone is the "Pulsar in a box" version of a Pulsar cluster, > where > a

Re: [DISCUSS] Proceeding with PIP-62 plan, before Apache Pulsar 2.10.0 is released

2021-12-22 Thread Sijie Guo
Sorry. When you say "we discussed", who are "we"? Is it DataStax? I believe we want to keep SQL until the code change lands in Trino. Because there are still users using this component. - Sijie On Tue, Dec 21, 2021 at 11:34 PM Enrico Olivelli wrote: > Lari, > > Il giorno mer 22 dic 2021 alle o

Re: [VOTE] Pulsar Release 2.7.4 Candidate 2

2021-12-22 Thread Hiroyuki Sakai
+1 (binding) - Check signatures/checksums - Check the license headers - build sources - Validate Pub/Sub and Java Functions - Validate Connectors - Validate Stateful Functions Regards, Hiroyuki From: guo jiwei Sent: Tuesday, December 21, 2021 18:33 To: de

[GitHub] [pulsar-client-node] izumo27 commented on issue #99: Authenticating using a Token

2021-12-22 Thread GitBox
izumo27 commented on issue #99: URL: https://github.com/apache/pulsar-client-node/issues/99#issuecomment-127066 @Matt-Esch What kind of environment did you use? Can you tell us the details of the issue? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-manager] shiv4289 commented on a change in pull request #434: SAML Integration for Login

2021-12-22 Thread GitBox
shiv4289 commented on a change in pull request #434: URL: https://github.com/apache/pulsar-manager/pull/434#discussion_r774308333 ## File path: src/main/java/org/apache/pulsar/manager/controller/SSOController.java ## @@ -0,0 +1,131 @@ +/** + * Licensed under the Apache License,

[GitHub] [pulsar-manager] shiv4289 commented on a change in pull request #434: SAML Integration for Login

2021-12-22 Thread GitBox
shiv4289 commented on a change in pull request #434: URL: https://github.com/apache/pulsar-manager/pull/434#discussion_r774308333 ## File path: src/main/java/org/apache/pulsar/manager/controller/SSOController.java ## @@ -0,0 +1,131 @@ +/** + * Licensed under the Apache License,

Re: [DISCUSS] Add definition to our cherry picking process

2021-12-22 Thread Michael Marshall
I am very interested in Jonathan's proposal. I think we could really benefit from a workflow that keeps branches in a (near) ready to release state and prioritizes the stability of our active branches. It would be great to hear from other community members regarding our current process, its benefi

Re: [DISCUSS] Proceeding with PIP-62 plan, before Apache Pulsar 2.10.0 is released

2021-12-22 Thread Michael Marshall
> I am volunteering to making the changes as per the PIP-62 plan. I think Lari is proposing to complete the work to move the Pulsar SQL code base to the repositories defined in PIP 62. Assuming that is what he meant, I am +1 on completing that now. Based on reading through the mailing list thread

Re: [VOTE] PIP-117: Change Pulsar standalone defaults

2021-12-22 Thread Michael Marshall
+1 - Michael On Wed, Dec 22, 2021 at 6:18 PM Sijie Guo wrote: > > +1 > > On Tue, Dec 21, 2021 at 3:49 PM Matteo Merli wrote: > > > This is the voting thread for PIP-117. It will stay open for at least 48h. > > > > https://github.com/apache/pulsar/issues/13302 > > > > > > > > ## Motivation

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-22 Thread Michael Marshall
That makes sense, thank you for your explanation, Matteo. - Michael On Tue, Dec 21, 2021 at 4:03 PM Matteo Merli wrote: > > > Did you consider determining the default limit by inspecting the JVM's > > runtime? > > For example, in the broker, we set `maxMessagePublishBufferSizeInMB` to 1/2 > > o

Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-22 Thread Michael Marshall
+1 - Michael On Wed, Dec 22, 2021 at 6:17 PM Sijie Guo wrote: > > +1 > > On Tue, Dec 21, 2021 at 3:23 PM Matteo Merli wrote: > > > This is the voting thread for PIP-119. It will stay open for at least 48h. > > > > https://github.com/apache/pulsar/issues/13305 > > > > --- > > > > ## Moti

Re: [VOTE] PIP-123: Introduce Pulsar metadata CLI tool

2021-12-22 Thread Michael Marshall
+1 - Michael On Wed, Dec 22, 2021 at 6:18 PM Sijie Guo wrote: > > +1 > > On Tue, Dec 21, 2021 at 3:59 PM Matteo Merli wrote: > > > This is the voting thread for PIP-123. It will stay open for at least 48h. > > > > https://github.com/apache/pulsar/issues/13346 > > > > > > - > > ## Motiva