volgorean commented on pull request #74:
URL: https://github.com/apache/pulsar-helm-chart/pull/74#issuecomment-726603344
@sijie Done :)
This is an automated message from the Apache Git Service.
To respond to the message, plea
jeantil commented on pull request #80:
URL: https://github.com/apache/pulsar-helm-chart/pull/80#issuecomment-726654784
@sijie @wolfstudy I rebased on master and incremented the version to 2.6.2-2
The lint task is green but I think it actually failed, the following comes
up as a warni
Hi Sijie,
I had added a PIP style document to the pull request:
https://github.com/andrekramer1/pulsar/blob/consumer-filter2-7-0/PIP-XX%20-%20Consumer-filtering.pdf
Hopefully that could be used to start the discussion?
Regards,
Andre
-Original Message-
From: Sijie Guo
Sent: 12 Novembe
jeantil commented on a change in pull request #75:
URL: https://github.com/apache/pulsar-helm-chart/pull/75#discussion_r522970428
##
File path: scripts/pulsar/generate_token.sh
##
@@ -111,11 +127,11 @@ function pulsar::jwt::generate_asymmetric_token() {
trap "test -f $priv
jeantil commented on a change in pull request #75:
URL: https://github.com/apache/pulsar-helm-chart/pull/75#discussion_r522970428
##
File path: scripts/pulsar/generate_token.sh
##
@@ -111,11 +127,11 @@ function pulsar::jwt::generate_asymmetric_token() {
trap "test -f $priv
Andre,
Is it possible to put it in a Google Doc (or similar collaboration tool)
that allows other people to make comments? Also, it would be easier for the
committers to copy the PIP to Pulsar wiki pages.
Thanks,
Sijie
On Fri, Nov 13, 2020 at 2:44 AM Kramer, Andre
wrote:
> Hi Sijie,
>
> I had