jeantil commented on a change in pull request #75:
URL: https://github.com/apache/pulsar-helm-chart/pull/75#discussion_r522970428
##########
File path: scripts/pulsar/generate_token.sh
##########
@@ -111,11 +127,11 @@ function pulsar::jwt::generate_asymmetric_token() {
trap "test -f $privatekeytmpfile && rm $privatekeytmpfile" RETURN
tokentmpfile=$(mktemp)
trap "test -f $tokentmpfile && rm $tokentmpfile" RETURN
- kubectl get -n ${namespace} secrets ${secret_name} -o
jsonpath="{.data['PRIVATEKEY']}" | base64 --decode > ${privatekeytmpfile}
+ pulsar::jwt::get_secret SECRETKEY ${tmpfile}
Review comment:
this should have been `${privatekeytmpfile}`, fixed in #80 through
3185b14d5c97e24e9de02d0d07f7be4434d38f99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
