[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
blankensteiner commented on a change in pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47#discussion_r446645265 ## File path: src/DotPulsar/Internal/Consumer.cs ## @@ -104,6 +107,12 @@ public async ValueTask AcknowledgeCumulative(Message message, Cancel

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
blankensteiner commented on pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47#issuecomment-650746865 Almost done now :-) This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
dionjansen commented on a change in pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47#discussion_r446670611 ## File path: src/DotPulsar/Internal/Consumer.cs ## @@ -104,6 +107,12 @@ public async ValueTask AcknowledgeCumulative(Message message, Cancellati

[GitHub] [pulsar-dotpulsar] dionjansen commented on pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
dionjansen commented on pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47#issuecomment-650789784 @blankensteiner my bad, added the configureAwaits for the consumer methods, let me know if there are any other issues :) ---

[GitHub] [pulsar-dotpulsar] blankensteiner merged pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
blankensteiner merged pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #47: Redeliver unacknowledged messages

2020-06-28 Thread GitBox
blankensteiner commented on pull request #47: URL: https://github.com/apache/pulsar-dotpulsar/pull/47#issuecomment-650790980 Thanks for the PR! :-) This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-manager] tuteng merged pull request #300: Bundle BKVM.org - BookKeeper Visual Manager 1.2.0

2020-06-28 Thread GitBox
tuteng merged pull request #300: URL: https://github.com/apache/pulsar-manager/pull/300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-manager] tuteng merged pull request #286: Use Pulsar Admin instead of HttpUtil

2020-06-28 Thread GitBox
tuteng merged pull request #286: URL: https://github.com/apache/pulsar-manager/pull/286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-manager] tuteng closed issue #249: [Refactoring] Use Pulsar Admin instead of HttpUtil

2020-06-28 Thread GitBox
tuteng closed issue #249: URL: https://github.com/apache/pulsar-manager/issues/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar-manager] tuteng commented on issue #310: Support for TLS Authentication & Authorization

2020-06-28 Thread GitBox
tuteng commented on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-650853783 This feature has been supported here, and I will release a new version recently. At present, you can add the following configuration to enable this feature based on the latest co

[GitHub] [pulsar-manager] tuteng edited a comment on issue #310: Support for TLS Authentication & Authorization

2020-06-28 Thread GitBox
tuteng edited a comment on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-650853783 This feature has been supported here https://github.com/apache/pulsar-manager/pull/286, and I will release a new version recently. At present, you can add the following co

[GitHub] [pulsar-manager] jaschnell commented on issue #310: Support for TLS Authentication & Authorization

2020-06-28 Thread GitBox
jaschnell commented on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-650856588 What are the possible values for the 1st two parameters. Is the tlstrustcertfilepath the path to the ca cert or the cert for the role with admin privs? What ab

[GitHub] [pulsar-manager] sijie commented on issue #310: Support for TLS Authentication & Authorization

2020-06-28 Thread GitBox
sijie commented on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-650857506 > What are the possible values for the 1st two parameters. @jaschnell the first two values will be the same values you used for configuring a normal Pulsar client. ---

[GitHub] [pulsar-manager] sijie commented on issue #311: pulsar-manager generate token report error: Token generate failed

2020-06-28 Thread GitBox
sijie commented on issue #311: URL: https://github.com/apache/pulsar-manager/issues/311#issuecomment-650858197 @lvs071103 did @tuteng already help you on the wechat group? This is an automated message from the Apache Git Serv

[GitHub] [pulsar-manager] tuteng commented on issue #310: Support for TLS Authentication & Authorization

2020-06-28 Thread GitBox
tuteng commented on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-650859858 There seems to be some problem with the support of this pull request for tls authentication and authorization forwarding requests. I will test it ---

[GitHub] [pulsar-client-node] sijie commented on issue #99: Authenticating using a Token

2020-06-28 Thread GitBox
sijie commented on issue #99: URL: https://github.com/apache/pulsar-client-node/issues/99#issuecomment-650860688 How do you create the producer? Can you show us the code sample? This is an automated message from the Apache G

[GitHub] [pulsar-client-node] hrsakai commented on pull request #96: Fix consumer double close

2020-06-28 Thread GitBox
hrsakai commented on pull request #96: URL: https://github.com/apache/pulsar-client-node/pull/96#issuecomment-650906062 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar-client-node] hrsakai merged pull request #96: Fix consumer double close

2020-06-28 Thread GitBox
hrsakai merged pull request #96: URL: https://github.com/apache/pulsar-client-node/pull/96 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-helm-chart] lukestephenson-zendesk commented on issue #26: pods for broker/bookkeeper init failed - Could not find or load main class "-Xms1g error

2020-06-28 Thread GitBox
lukestephenson-zendesk commented on issue #26: URL: https://github.com/apache/pulsar-helm-chart/issues/26#issuecomment-650948199 Similar, I'm trying the latest master and my bookies are now failing to start with: ``` Error: Could not find or load main class " JMX enabled by defaul