blankensteiner commented on a change in pull request #47:
URL: https://github.com/apache/pulsar-dotpulsar/pull/47#discussion_r446645265
##########
File path: src/DotPulsar/Internal/Consumer.cs
##########
@@ -104,6 +107,12 @@ public async ValueTask AcknowledgeCumulative(Message
message, CancellationToken
public async ValueTask AcknowledgeCumulative(MessageId messageId,
CancellationToken cancellationToken)
=> await Acknowledge(messageId.Data,
CommandAck.AckType.Cumulative, cancellationToken).ConfigureAwait(false);
+ public async ValueTask
RedeliverUnacknowledgedMessages(IEnumerable<MessageId> messageIds,
CancellationToken cancellationToken)
+ => await RedeliverUnacknowledgedMessages(messageIds.Select(m =>
m.Data).ToList(), cancellationToken);
Review comment:
We need a .ConfigureAwait(false); here :-)
##########
File path: src/DotPulsar/Internal/Consumer.cs
##########
@@ -104,6 +107,12 @@ public async ValueTask AcknowledgeCumulative(Message
message, CancellationToken
public async ValueTask AcknowledgeCumulative(MessageId messageId,
CancellationToken cancellationToken)
=> await Acknowledge(messageId.Data,
CommandAck.AckType.Cumulative, cancellationToken).ConfigureAwait(false);
+ public async ValueTask
RedeliverUnacknowledgedMessages(IEnumerable<MessageId> messageIds,
CancellationToken cancellationToken)
+ => await RedeliverUnacknowledgedMessages(messageIds.Select(m =>
m.Data).ToList(), cancellationToken);
+
+ public async ValueTask
RedeliverUnacknowledgedMessages(CancellationToken cancellationToken)
+ => await
RedeliverUnacknowledgedMessages(Enumerable.Empty<MessageId>(),
cancellationToken);
Review comment:
We need a .ConfigureAwait(false); here :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
